Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Alarm Lights (Lit version) (Also lumin cleanup) #80384

Merged
merged 3 commits into from Dec 17, 2023

Conversation

LemonInTheDark
Copy link
Member

@LemonInTheDark LemonInTheDark commented Dec 16, 2023

About The Pull Request

Removes redundant uses of luminosity

I had a bunch of these left over from an old pr, sweep sweep (Made redundant because mobs can see through all byond darkness now)

Starts working on the fire alarm lighting

Dimmer but wider fire alarms, dimmer but MUCH wider lights. The idea is to highlight fire alarms while providing a not pitchblack but vibey space.

Why It's Good For The Game

2023-12-16.00-25-37.mp4

Looks nice

Changelog

🆑
fix: Fire alarms no longer cause pitch blackness, instead creating a dark but not black red light.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Dec 16, 2023
@Time-Green Time-Green merged commit 0638b11 into tgstation:master Dec 17, 2023
22 checks passed
comfyorange added a commit that referenced this pull request Dec 17, 2023
github-actions bot added a commit that referenced this pull request Dec 17, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Dec 20, 2023
…anup) (#9074)

Original PR: tgstation/tgstation#80384
-----

## About The Pull Request
[Removes redundant uses of
luminosity](tgstation/tgstation@dd4ec1f)

I had a bunch of these left over from an old pr, sweep sweep (Made
redundant because mobs can see through all byond darkness now)

[Starts working on the fire alarm
lighting](tgstation/tgstation@b555ba0)

Dimmer but wider fire alarms, dimmer but MUCH wider lights. The idea is
to highlight fire alarms while providing a not pitchblack but vibey
space.

## Why It's Good For The Game


https://github.com/tgstation/tgstation/assets/58055496/5058bab4-0b04-4891-82d7-e3130711e5d0

Looks nice

## Changelog
:cl:
fix: Fire alarms no longer cause pitch blackness, instead creating a
dark but not black red light.
/:cl:

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants