Refactors pod launcher UI #80887
Merged
Refactors pod launcher UI #80887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Refactor
|
does this change the functionality or look of the UI at all, or just an under-the-hood refactor? |
moved preset menu buttons around slightly |
jlsnow301
commented
Jan 11, 2024
tgui/packages/tgui/interfaces/CentcomPodLauncher/PodStatusPage.tsx
Outdated
Show resolved
Hide resolved
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 15, 2024
Original PR: tgstation/tgstation#80887 ----- ## About The Pull Request While debugging #80857, it became immediately apparent why it was never converted over to TypeScript: It's massive. 1203 lines in one file, making it our largest UI! I stated in the aforementioned PR my general guideline: 500 lines before something needs to be separated. This does so. ## Why It's Good For The Game - Separates a titanic UI component for easier maintainability - Typescript conversion ## Changelog N/A nothing player facing --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
While debugging #80857, it became immediately apparent why it was never converted over to TypeScript: It's massive. 1203 lines in one file, making it our largest UI! I stated in the aforementioned PR my general guideline: 500 lines before something needs to be separated. This does so.
Why It's Good For The Game
Changelog
N/A nothing player facing