Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A red spy has entered the base: Adds Spies, a roundstart antagonist inspired by Goonstation's Spy-Thief #81231

Merged
merged 74 commits into from Mar 1, 2024

Conversation

MrMelbert
Copy link
Contributor

Disclaimer: No Goon code was referenced or used in the making of this PR

About The Pull Request

Design Document (Read this for more information)

This PR adds Spies as a new roundstart antagonist type, inspired by Spy-Thiefs from Goonstation.

Spies are tasked with stealing various objects around the station, from insulated gloves to the black box, from the clown's left leg to the bridge's communications console.

For every item stolen, the Spy is rewarded with a random item from the Syndicate Uplink, plus some items uniquely available to the Spy. Stolen items are then shipped off and sold on the Black Market Uplink, allowing the crew - or maybe some other evil-doers - to get their hands on them.

image

More ideas for theft items and bounties are welcome.

Why It's Good For The Game

See the design document for more information.

In short: Adds a solo antagonist which has less impact than your Traitors and Heretics, but more impact than Paradox Clones and Thieves. In other words: On the same tier as old traitors.

Seeks to embrace the sandbox aspect of antagonists more by having no precise greentext objective, and instead some suggestions for chaos you can embark in. Have fun with it!

Changelog

🆑 Melbert
add: Spies may now roam the halls of Space Station 13. Watch your belongings closely.
/:cl:

@MrMelbert
Copy link
Contributor Author

MrMelbert commented Feb 28, 2024

The purpose of thief is to be a lesser antag than traitor

This is not the purpose of thief. It's supposed to be on par with traitor.

Adding more reward items( especially disguising, stealing tools specifically designed for thieving) to the pool

Feel free to suggest more. Almost all uplink items (and then some) items are in the pool. Only some high tier nuke ops loot is not whitelisted.

For example: Physical stacks of minerals

This would only work if minerals were actually difficult to access and not in every single department

the ORM and Ore silo

I considered these but I decided against it.

the surgery tables in medbay which nowadays every doctor uses frequently to heal people

Operating computer are in the pool but I felt no need to add surgical tables since they're literally just silver tables that anyone could make.

There's an argument to be made for stasis beds, and they may come later, but I decided against it for now.

Lastly, the PDA-scans when stealing something should be silent and non-visual

Nah. Be more stealthy.

@bigfatbananacyclops
Copy link
Contributor

The purpose of thief is to be a lesser antag than traitor

This is not the purpose of thief. It's supposed to be on par with traitor.

Adding more reward items( especially disguising, stealing tools specifically designed for thieving) to the pool

Feel free to suggest more. Almost all uplink items (and then some) items are in the pool. Only some high tier nuke ops loot is not whitelisted.

For example: Physical stacks of minerals

This would only work if minerals were actually difficult to access and not in every single department

the ORM and Ore silo

I considered these but I decided against it.

the surgery tables in medbay which nowadays every doctor uses frequently to heal people

Operating computer are in the pool but I felt no need to add surgical tables since they're literally just silver tables that anyone could make.

There's an argument to be made for stasis beds, and they may come later, but I decided against it for now.

Lastly, the PDA-scans when stealing something should be silent and non-visual

Nah. Be more stealthy.

Dear Mr Melbert,

Ore stacks are in fact easy to steal, the consequence is pissing off the crew but i agree it shouldnt be a higher degree of objective.

Regarding the statis beds, if it weren't a single statis bed it would be more impactful.

@SomeoneYouProbablyKnow
Copy link
Contributor

Ore stacks are in fact easy to steal, the consequence is pissing off the crew

Yea it pisses off the crew but it's not high profile enough for people to figure out who did it. Unless you put no effort in hiding it but that's kinda... the whole point of the antag so.
Idk get a disguise, a fake ID, put a signaller on a fuel tank in adjacent maints to distract people, use a hidden away lathe like the engi one, no one ever checks the engi lathe, pay the clown to do it.

code/game/gamemodes/objective_items.dm Outdated Show resolved Hide resolved
@@ -271,6 +271,24 @@
/obj/item/storage/pill_bottle/penacid = 1)
generate_items_inside(items_inside,src)

/obj/item/storage/medkit/tactical_lite
name = "combat first aid kid"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'kid'

code/modules/antagonists/spy/spy_bounty.dm Outdated Show resolved Hide resolved
code/modules/antagonists/spy/spy_bounty.dm Show resolved Hide resolved
@Ghommie Ghommie enabled auto-merge (squash) March 1, 2024 04:34
@Ghommie Ghommie merged commit 977799a into tgstation:master Mar 1, 2024
18 of 19 checks passed
comfyorange added a commit that referenced this pull request Mar 1, 2024
github-actions bot added a commit that referenced this pull request Mar 1, 2024
@MrMelbert MrMelbert deleted the spy_two_electric_boogaloo branch March 1, 2024 05:01
larentoun pushed a commit to larentoun/tgstation that referenced this pull request Mar 1, 2024
…nspired by Goonstation's Spy-Thief (tgstation#81231)

# Disclaimer: No Goon code was referenced or used in the making of this
PR

## About The Pull Request

[Design Document (Read this for more
information)](https://hackmd.io/@L9JPMsZhRO2wI25rNI6GYg/rkYKM9Yc6)

This PR adds Spies as a new roundstart antagonist type, inspired by
Spy-Thiefs from Goonstation.

Spies are tasked with stealing various objects around the station, from
insulated gloves to the black box, from the clown's left leg to the
bridge's communications console.

For every item stolen, the Spy is rewarded with a random item from the
Syndicate Uplink, plus some items uniquely available to the Spy. Stolen
items are then shipped off and sold on the Black Market Uplink, allowing
the crew - or maybe some other evil-doers - to get their hands on them.


![image](https://github.com/tgstation/tgstation/assets/51863163/f057d480-4545-44da-b8fe-a8d09a5d2dcf)

More ideas for theft items and bounties are welcome. 

## Why It's Good For The Game

See the design document for more information. 

In short: Adds a solo antagonist which has less impact than your
Traitors and Heretics, but more impact than Paradox Clones and Thieves.
In other words: On the same tier as old traitors.

Seeks to embrace the sandbox aspect of antagonists more by having no
precise greentext objective, and instead some suggestions for chaos you
can embark in. Have fun with it!

## Changelog

:cl: Melbert
add: Spies may now roam the halls of Space Station 13. Watch your
belongings closely.
/:cl:
larentoun pushed a commit to larentoun/tgstation that referenced this pull request Mar 1, 2024
larentoun pushed a commit to larentoun/tgstation that referenced this pull request Mar 1, 2024
…nspired by Goonstation's Spy-Thief (tgstation#81231)

# Disclaimer: No Goon code was referenced or used in the making of this
PR

## About The Pull Request

[Design Document (Read this for more
information)](https://hackmd.io/@L9JPMsZhRO2wI25rNI6GYg/rkYKM9Yc6)

This PR adds Spies as a new roundstart antagonist type, inspired by
Spy-Thiefs from Goonstation.

Spies are tasked with stealing various objects around the station, from
insulated gloves to the black box, from the clown's left leg to the
bridge's communications console.

For every item stolen, the Spy is rewarded with a random item from the
Syndicate Uplink, plus some items uniquely available to the Spy. Stolen
items are then shipped off and sold on the Black Market Uplink, allowing
the crew - or maybe some other evil-doers - to get their hands on them.


![image](https://github.com/tgstation/tgstation/assets/51863163/f057d480-4545-44da-b8fe-a8d09a5d2dcf)

More ideas for theft items and bounties are welcome. 

## Why It's Good For The Game

See the design document for more information. 

In short: Adds a solo antagonist which has less impact than your
Traitors and Heretics, but more impact than Paradox Clones and Thieves.
In other words: On the same tier as old traitors.

Seeks to embrace the sandbox aspect of antagonists more by having no
precise greentext objective, and instead some suggestions for chaos you
can embark in. Have fun with it!

## Changelog

:cl: Melbert
add: Spies may now roam the halls of Space Station 13. Watch your
belongings closely.
/:cl:
larentoun pushed a commit to larentoun/tgstation that referenced this pull request Mar 1, 2024
larentoun pushed a commit to ss220club/Bandastation that referenced this pull request Mar 1, 2024
…nspired by Goonstation's Spy-Thief (tgstation#81231)

# Disclaimer: No Goon code was referenced or used in the making of this
PR

## About The Pull Request

[Design Document (Read this for more
information)](https://hackmd.io/@L9JPMsZhRO2wI25rNI6GYg/rkYKM9Yc6)

This PR adds Spies as a new roundstart antagonist type, inspired by
Spy-Thiefs from Goonstation.

Spies are tasked with stealing various objects around the station, from
insulated gloves to the black box, from the clown's left leg to the
bridge's communications console.

For every item stolen, the Spy is rewarded with a random item from the
Syndicate Uplink, plus some items uniquely available to the Spy. Stolen
items are then shipped off and sold on the Black Market Uplink, allowing
the crew - or maybe some other evil-doers - to get their hands on them.


![image](https://github.com/tgstation/tgstation/assets/51863163/f057d480-4545-44da-b8fe-a8d09a5d2dcf)

More ideas for theft items and bounties are welcome. 

## Why It's Good For The Game

See the design document for more information. 

In short: Adds a solo antagonist which has less impact than your
Traitors and Heretics, but more impact than Paradox Clones and Thieves.
In other words: On the same tier as old traitors.

Seeks to embrace the sandbox aspect of antagonists more by having no
precise greentext objective, and instead some suggestions for chaos you
can embark in. Have fun with it!

## Changelog

:cl: Melbert
add: Spies may now roam the halls of Space Station 13. Watch your
belongings closely.
/:cl:
larentoun pushed a commit to ss220club/Bandastation that referenced this pull request Mar 1, 2024
larentoun pushed a commit to ss220club/Bandastation that referenced this pull request Mar 1, 2024
…nspired by Goonstation's Spy-Thief (tgstation#81231)

# Disclaimer: No Goon code was referenced or used in the making of this
PR

## About The Pull Request

[Design Document (Read this for more
information)](https://hackmd.io/@L9JPMsZhRO2wI25rNI6GYg/rkYKM9Yc6)

This PR adds Spies as a new roundstart antagonist type, inspired by
Spy-Thiefs from Goonstation.

Spies are tasked with stealing various objects around the station, from
insulated gloves to the black box, from the clown's left leg to the
bridge's communications console.

For every item stolen, the Spy is rewarded with a random item from the
Syndicate Uplink, plus some items uniquely available to the Spy. Stolen
items are then shipped off and sold on the Black Market Uplink, allowing
the crew - or maybe some other evil-doers - to get their hands on them.


![image](https://github.com/tgstation/tgstation/assets/51863163/f057d480-4545-44da-b8fe-a8d09a5d2dcf)

More ideas for theft items and bounties are welcome. 

## Why It's Good For The Game

See the design document for more information. 

In short: Adds a solo antagonist which has less impact than your
Traitors and Heretics, but more impact than Paradox Clones and Thieves.
In other words: On the same tier as old traitors.

Seeks to embrace the sandbox aspect of antagonists more by having no
precise greentext objective, and instead some suggestions for chaos you
can embark in. Have fun with it!

## Changelog

:cl: Melbert
add: Spies may now roam the halls of Space Station 13. Watch your
belongings closely.
/:cl:
larentoun pushed a commit to ss220club/Bandastation that referenced this pull request Mar 1, 2024
@sylvia-from-fulp-station
Copy link
Contributor

"Ensure no members of @pick(department) @pick(escape) the station.",

This is incredibly impactful more so than any traitor objective, primary or secondary. A traitor with die a glorious death could feasibly cause more destruction, and anyone hijacking the shuttle could kill the whole crew, (in the last 3 minutes of the round) but both of those objectives are rare because of their impact.

"Ensure no heads of staff @pick(escape) the station.",

During a rev round this situation is deemed so unbalanced it ends the game; here it is untracked.

I suggest removing these or changing them to be less impactful but still open to interpretation; eg,
Ensure all members of x department are; sent to Medical, gravely wounded, victim to a workplace accident

"affected": [
"ablaze",
"burning",
"covered in blood",
"demolished",
"destroyed",
"engulfed in flames",
"obliterated",
"on fire",
"ruined",
"sabotaged",
"wrecked"
],

Departments are affected in a few different ways, for their personnel right now it is just 5 different ways to say make sure they don't leave. You CAN interpret this as build a silly little maze to stop them from leaving, but nobody will. I have only seen the objective go un-attempted, or an entire department round removed.
"escape": [
"depart",
"escape",
"evacuate",
"flee",
"leave"
]

Finally, i think you should experiment with progressive tiers of loot for the steal rewards, getting nuke ops gear isn't possible for anyone other than nuke ops who are some of the rarest antags in the game and it's potentially available to spys roundstart.

ancient-engineer added a commit to ancient-engineer/Monkestation2.0 that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes. 📌 Test Merge Candidate This version will not be removed by actions when the PR is updated UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet