moon smile effect durations fix #81794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
|
Not that this needs this but Yeah this was the intent of the original pr |
Ghommie
reviewed
Mar 4, 2024
| @@ -28,7 +28,8 @@ | |||
| /datum/action/cooldown/spell/pointed/moon_smile/cast(mob/living/carbon/human/cast_on) | |||
| . = ..() | |||
| /// The duration of these effects are based on sanity, mainly for flavor but also to make it a weaker alpha strike | |||
| var/moon_smile_duration = (150 - cast_on.mob_mood.sanity) / 10 | |||
| var/maximum_duration = 15 SECONDS | |||
| var/moon_smile_duration = ((SANITY_MAXIMUM - cast_on.mob_mood.sanity) / (SANITY_MAXIMUM - SANITY_INSANE)) * maximum_duration | |||
There was a problem hiding this comment.
Suggested change
| var/moon_smile_duration = ((SANITY_MAXIMUM - cast_on.mob_mood.sanity) / (SANITY_MAXIMUM - SANITY_INSANE)) * maximum_duration | |
| var/moon_smile_duration = ((SANITY_MAXIMUM - cast_on.mob_mood.sanity) / SANITY_MAXIMUM) * maximum_duration |
the SANITY_INSANE value is 0 anyway.
There was a problem hiding this comment.
I know, but just in case it ever changes, I use the define so that the scaling stays accurate.
comfyorange
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Moon smile's durations had some syntax issues, causing their durations to be much lower than intended, and sanity having very low impact on it. Also adds a use of SANITY_MAXIMUM define, so that the calculation will still work if this value is ever changed.
Why It's Good For The Game
The moon did not smile. It was frowning. Frowning because it was bugged :( But with this fix it can smile again :)
Changelog
馃啈
fix: fixed some issues when calculating the duration of moon smile's effects
/:cl: