Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds minimum dynamic threat threshold for War Ops #81854

Closed
wants to merge 2 commits into from

Conversation

JoshAdamPowell
Copy link
Contributor

@JoshAdamPowell JoshAdamPowell commented Mar 6, 2024

About The Pull Request

This should allow war ops to only happen if the threat is above a certain level.

Why It's Good For The Game

Unlike other round-ending game-modes (eg cult/revs) This game mode makes everyone act differently and ruins the round for anyone who wants to act normally. What is the point of a chef when the station is either getting nuked in 30 minutes or evacuated in 30?

Changelog

🆑
balance: war ops requires threat
admin: added an admin threat limit for war ops
server: something server ops should know
/:cl:

I'm fairly certain this isn;t enough code to do the thing I want to but I'm not gonna do more code before I;m at least relatively certain this code is liked by the powers that be :)

@tgstation-server tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Administration As generous gods, we have deigned to throw the jannies a bone labels Mar 6, 2024
@tgstation tgstation locked as too heated and limited conversation to collaborators Mar 6, 2024
@optimumtact optimumtact self-assigned this Mar 6, 2024
@optimumtact
Copy link
Member

@MrMelbert MrMelbert changed the title I hate war Ops Adds minimum dynamic threat threshold for War Ops Mar 6, 2024
Comment on lines +1 to +4
/datum/antagonist/nukeop
name = ROLE_NUCLEAR_OPERATIVE
roundend_category = "syndicate operatives" //just in case
antagpanel_category = ANTAG_GROUP_SYNDICATE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk what's going on here but you seem to have re-added the entirety of the nuke op datum, and I don't know why. I think someone moved its file recently so that might be your problem.

@MrMelbert MrMelbert marked this pull request as draft March 6, 2024 00:21
@MrMelbert
Copy link
Contributor

MrMelbert commented Mar 6, 2024

Also I guess this technically exists already?

image

@Watermelon914
Copy link
Member

Also I guess this technically exists already?

image

I think the idea is to disable warops aka declaring war, not nukeops

@Watermelon914
Copy link
Member

Isn't this something that already basically exists as a population lock?
I.e. can't declare war unless there are 40 or more players.

@Fikou
Copy link
Member

Fikou commented Apr 9, 2024

What is the point of a chef when the station is getting nuked in 10 minutes instead of 30

@optimumtact
Copy link
Member

before you make this next time please check with headadmins and headcoders to come up with a design for what you want to achieve.

mostly this PR just confused them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Administration As generous gods, we have deigned to throw the jannies a bone Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants