Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Might fix reagent loop #81952

Merged
merged 6 commits into from Mar 11, 2024
Merged

Might fix reagent loop #81952

merged 6 commits into from Mar 11, 2024

Conversation

optimumtact
Copy link
Member

@optimumtact optimumtact commented Mar 11, 2024 •
edited

There's potentially an infinite loop if the amount to remove falls below the min quantization level.

@optimumtact @MrStonedOne
Update code/modules/reagents/chemistry/holder/holder.dm
f65c158 
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
@Kylerace Kylerace merged commit a4e39ba into tgstation:master Mar 11, 2024
19 checks passed
@SkyratBot SkyratBot mentioned this pull request Mar 11, 2024
Merged
@NovaBot13 NovaBot13 mentioned this pull request Mar 11, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024 •
edited

This pull request was test merged in 96 round(s).

Round list

terry

@Steals-The-PRs Steals-The-PRs mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrStonedOne MrStonedOne MrStonedOne left review comments

@Kylerace Kylerace Kylerace approved these changes

@ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone Awaiting requested review from ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@optimumtact @MrStonedOne @Kylerace