Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[april fools] Makes robotics more realistic #82351

Closed

Conversation

NamelessFairy
Copy link
Member

@NamelessFairy NamelessFairy commented Mar 31, 2024

About The Pull Request

SS13 mech construction is extremely unrealistic, you just print parts at the mechfab and stick them together. This PR remedies this and helps put a greater enthesis on realism.

Why It's Good For The Game

Gives players a sense of pride and accomplishment when assembling a mech.

Changelog

馃啈
qol: Players familiar with IRL robot construction will now be able to apply their experience to the ingame version
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. April Fools This is going to ruin the upcoming week Quality of Life Increasing esword damage is not a quality of life for traitors labels Mar 31, 2024
Copy link
Contributor

@Wallemations Wallemations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My set didn't ship with a piece


/obj/item/mecha_parts/proc/try_attach_part(mob/user, obj/vehicle/sealed/mecha/M, attach_right = FALSE) //For attaching parts to a finished mech
if(!user.transferItemToLoc(src, M))
to_chat(user, span_warning("\The [src] is stuck to your hand, you cannot put it in \the [M]!"))
return FALSE
if(runner == TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you do if(runner) in some places and if(runner == true) in others

runner = FALSE
user.visible_message(span_notice("[user] snips [src] from its runner."), span_notice("You snip [src] from its runner."))
new /obj/item/runner(get_turf(src), runner_color)
underlays.Cut()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't


/obj/item/runner/Initialize(mapload, color)
. = ..()
if(color)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's it for?

@ArcaneMusic
Copy link
Contributor

Oh god damnit it's a gundam reference

Copy link
Contributor

github-actions bot commented Apr 1, 2024

This pull request was test merged in 72 round(s).

Round list

terry

manuel

sybil

@ZephyrTFA ZephyrTFA closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
April Fools This is going to ruin the upcoming week Quality of Life Increasing esword damage is not a quality of life for traitors Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants