Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller Overview UI #82739

Merged
merged 7 commits into from Apr 19, 2024
Merged

Controller Overview UI #82739

merged 7 commits into from Apr 19, 2024

Conversation

ZephyrTFA
Copy link
Contributor

About The Pull Request

Adds a fancy tgui window for looking at all controllers and sorting them based on specific stats.

Why It's Good For The Game

Easier investigation and looking at SS as a whole.
Also I think it's neat.

Changelog

馃啈
admin: Controller Overview UI. Check the Server Tab.
/:cl:

@tgstation-server tgstation-server added Administration As generous gods, we have deigned to throw the jannies a bone UI We make the game less playable, but with round edges labels Apr 18, 2024
jlsnow301
jlsnow301 reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jlsnow301 jlsnow301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aces. Just some code nits.

tgui/packages/tgui/interfaces/ControllerOverview.tsx Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/ControllerOverview.tsx Show resolved Hide resolved
tgui/packages/tgui/interfaces/ControllerOverview.tsx Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/ControllerOverview.tsx Outdated Show resolved Hide resolved
@ZephyrTFA @jlsnow301
touchups and use memo
4732bee 
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
@jlsnow301
Copy link
Contributor

jlsnow301 commented Apr 18, 2024 •
edited

tried this in round, doesn't give enough info at a glance yet, which is what i think it was designed to do. i think it needs:

  1. a modal instead of collapsibles
  2. progressbars instead of buttons
  3. scrollable on the ss overview section, not window.content
  4. cost sort
  5. labeledlist in master overivew

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited

This pull request was test merged in 50 round(s).

Round list

terry

sybil

manuel

@ZephyrTFA
Copy link
Contributor Author

tried this in round, doesn't give enough info at a glance yet, which is what i think it was designed to do. i think it needs:

  1. a modal instead of collapsibles
  2. progressbars instead of buttons
  3. scrollable on the ss overview section, not window.content
  4. cost sort
  5. labeledlist in master overivew

3-5 are done, not doing 1,2

@jlsnow301 jlsnow301 merged commit e51a1f9 into tgstation:master Apr 19, 2024
19 checks passed
github-actions bot added a commit that referenced this pull request Apr 19, 2024
@github-actions
Updating GBP balances for #82739
9445ab7
comfyorange added a commit that referenced this pull request Apr 19, 2024
@comfyorange
Automatic changelog for PR #82739 [ci skip]
15bea63
@SkyratBot SkyratBot mentioned this pull request Apr 19, 2024
Closed
@NovaBot13 NovaBot13 mentioned this pull request Apr 19, 2024
Merged
@Steals-The-PRs Steals-The-PRs mentioned this pull request Apr 19, 2024
Merged
SpaceLoveSs13 pushed a commit to SpaceLoveSs13/tgstation that referenced this pull request Apr 23, 2024
@ZephyrTFA @SpaceLoveSs13
Controller Overview UI (tgstation#82739)
a9931be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlsnow301 jlsnow301 jlsnow301 left review comments

@MrStonedOne MrStonedOne Awaiting requested review from MrStonedOne

@stylemistake stylemistake Awaiting requested review from stylemistake

Assignees
No one assigned
Labels
Administration As generous gods, we have deigned to throw the jannies a bone UI We make the game less playable, but with round edges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZephyrTFA @jlsnow301 @tgstation-server