MapTileAggregator Fixup and Re-run #82819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
san7890
added
Fix
san7890
requested review from
EOBGames,
Maurukas,
MMMiracles and
ShizCalev
as code owners
tgstation-server
added
Tools
|
actually what the fuck is going on here |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Hey there,
It's been more than a year since the last time we ran this tool (introduced in #74169 (3156a04)), and it's caught a bunch more things. It was also slightly broken since we introduced a new subtype of
/obj/effect/decal/turf_decal(thetramsubtype) since it's introduction, but I just fixed it up real nice and quick in case anyone was planning on using it for their own things.Anyways, just good to have all of the keys be flattened and merged again, far nicer to edit individual tiles that might still have an excessive number of tile decals... more details are in the linked PR but it's nice to have this tool working again (especially for stuff that's in the map depot, yeesh)