Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements dynamic scaling for spies #82961

Merged
merged 4 commits into from
May 8, 2024

Conversation

MrMelbert
Copy link
Contributor

@MrMelbert MrMelbert commented Apr 29, 2024

About The Pull Request

Implements dynamic scaling for spies.

TL;DR On average less spawn, but there is a chance it scales up to add even more.

Old

image

New

image

Why It's Good For The Game

Maybe more dynamic rounds? Just for testing really

Changelog

馃啈 Melbert
qol: Spies may spawn in less numbers, but rarely may also spawn in more numbers.
/:cl:

@MrMelbert MrMelbert added 馃搶 Test Merge Candidate This version will not be removed by actions when the PR is updated Test Merge Only I'm too scared to suggest this as a real change. labels Apr 29, 2024
@tgstation-server tgstation-server added the Quality of Life Increasing esword damage is not a quality of life for traitors label Apr 29, 2024
@Sadboysuss
Copy link
Contributor

I think 10 spies, even for 100 is too much

@MrMelbert
Copy link
Contributor Author

I think 10 spies, even for 100 is too much

Is 5 spies for 50 players too much? It's the same percentage

@Sadboysuss
Copy link
Contributor

Sadboysuss commented May 2, 2024

I think 10 spies, even for 100 is too much

Is 5 spies for 50 players too much? It's the same percentage

in this case 5 spies seems ok but don't forget that sec slots don't go higher with more players, it's always 5 sec officer, 1 warden, 1 hos, 1 det and no more unless the HoP raises the slots, which is quite unlikely.
Might be ok but this isn't giving much of a fighting chance for sec (which they shouldn't have too much of a fighting chance anyways) because there are also other antags other than spy.

@Jacquerel
Copy link
Contributor

Jacquerel commented May 2, 2024

in this case 5 spies seems ok but don't forget that sec slots don't go higher with more players, it's always 5 sec officer, 1 warden, 1 hos, 1 det and no more unless the HoP raises the slots, which is quite unlikely.

I mean I don't know if some head admin has disabled it but we definitely have code to scale security officer job slots with population and our codebase is config-agnostic.
Defaults to one for every 8 players, minimum of 5 and maximum of 12.

@Sadboysuss
Copy link
Contributor

in this case 5 spies seems ok but don't forget that sec slots don't go higher with more players, it's always 5 sec officer, 1 warden, 1 hos, 1 det and no more unless the HoP raises the slots, which is quite unlikely.

I mean I don't know if some head admin has disabled it but we definitely have code to scale security officer job slots with population and our codebase is config-agnostic. Defaults to one for every 8 players, minimum of 5 and maximum of 12.

I've played on Manuel with over 40 players and it's always 5, so idk

Copy link
Contributor

github-actions bot commented May 2, 2024

This pull request was test merged in 98 round(s).

Round list

manuel

terry

@MrMelbert MrMelbert removed the Test Merge Only I'm too scared to suggest this as a real change. label May 7, 2024
@MrMelbert
Copy link
Contributor Author

MrMelbert commented May 7, 2024

ok in testing seems pretty... ok. headmins can tweak it further if they want

@delaron
Copy link

delaron commented May 7, 2024

I caution going much higher than 5. The pool of objectives being what it is might not functionally support 10 spies in a round. The degree of missing equipment can get annoyingly problematic when compared to security staffing and even engineering staff to build replacements. More than 5 likely would need a reduction in other threats generated.

@Jacquerel Jacquerel merged commit b116767 into tgstation:master May 8, 2024
27 of 29 checks passed
github-actions bot added a commit that referenced this pull request May 8, 2024
comfyorange added a commit that referenced this pull request May 8, 2024
Chowder-McArthor pushed a commit to Chowder-McArthor/desertbus13 that referenced this pull request Jun 6, 2024
## About The Pull Request

Implements dynamic scaling for spies. 

TL;DR On average less spawn, but there is a chance it scales up to add
even more.

Old


![image](https://github.com/tgstation/tgstation/assets/51863163/5ecdf146-7922-42ea-8051-8a30cddde7a6)

New


![image](https://github.com/tgstation/tgstation/assets/51863163/ce9f51a1-4d99-4fe7-be65-32003fbec605)

## Why It's Good For The Game

Maybe more dynamic rounds? Just for testing really

## Changelog

:cl: Melbert
qol: Spies may spawn in less numbers, but rarely may also spawn in more
numbers.
/:cl:
Chowder-McArthor pushed a commit to Chowder-McArthor/desertbus13 that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Increasing esword damage is not a quality of life for traitors 馃搶 Test Merge Candidate This version will not be removed by actions when the PR is updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants