Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turns bat knockback into an element and adds it to cleric maces #83368

Closed
wants to merge 6 commits into from

Conversation

carlarctg
Copy link
Contributor

@carlarctg carlarctg commented May 20, 2024

About The Pull Request

Turns bat knockback into an element and adds it to cleric maces.

To farm GBP, I also turned the knockback into a standard element.

Why It's Good For The Game

Cleric maces are pretty poop. Ruin-only, bulky, and with only slightly above average damage, there's little point to hauling one around most of the time as opposed to a welding tool or something. I saw the description referenced the baseball bat, but it doesn't actually the bat's knockback gimmick, which I think would be pretty damn useful for it to be 1. less useless and 2. more useful for the space explorers that will find it.

To farm GBP, I also turned the knockback into a standard element.

Now it can be added to other things yayyyyyyyyy

Changelog

馃啈
refactor: Turns baseball bat knockback into an element
add: and adds it to cleric maces
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Refactor Makes the code harder to read labels May 20, 2024
@ghost
Copy link

ghost commented May 21, 2024

well, there's also the disk that can print cleric maces via autolathe, and using titanium as the material gives it good AP and 7.8 hits to down iirc

@ghost
Copy link

ghost commented May 21, 2024

People stealing items to be able to see in the dark is preferable to them being born that way

wrong pr?

@carlarctg
Copy link
Contributor Author

well, there's also the disk that can print cleric maces via autolathe, and using titanium as the material gives it good AP and 7.8 hits to down iirc

5.6 and the disk is found where the mace is

@PKPenguin321
Copy link
Contributor

Make the distance/speed it throws you admin editable please :)

@MrMelbert MrMelbert marked this pull request as draft May 21, 2024 07:21
@Potato-Masher
Copy link
Contributor

Potato-Masher commented May 21, 2024

Does this do anything with the knockback component at all or is this separate

@carlarctg
Copy link
Contributor Author

Does this do anything with the knockback component at all or is this separate

there is no such thnig

@ZephyrTFA
Copy link
Contributor

don't forget about mjollnir

@carlarctg carlarctg marked this pull request as ready for review May 23, 2024 06:00
@carlarctg
Copy link
Contributor Author

don't forget about mjollnir

angry facef

@carlarctg
Copy link
Contributor Author

don't forget about mjollnir

Mjolnir uses different, more elaborate code. I am declaring it out of scope

@ZephyrTFA
Copy link
Contributor

it's not out of scope.
itr is a knock back effect with damage

@ZephyrTFA ZephyrTFA marked this pull request as draft May 24, 2024 01:32
@carlarctg
Copy link
Contributor Author

:(

@carlarctg carlarctg marked this pull request as ready for review May 24, 2024 15:37
@ZephyrTFA ZephyrTFA removed the Feature Exposes new bugs in interesting ways label May 24, 2024
@ZephyrTFA ZephyrTFA enabled auto-merge (squash) May 24, 2024 15:48
auto-merge was automatically disabled May 25, 2024 03:17

Head branch was pushed to by a user without write access

/// If the throw is violent or not
var/gentle = TRUE
/// Callback for a proc right before confirming the attack. If it returns FALSE, cancel
var/datum/callback/pre_hit_callback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to fix this or not, we already told you how on Discord

@Jacquerel
Copy link
Contributor

Reopen this when you want to work on it again

@Jacquerel Jacquerel closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Makes the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants