-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turns bat knockback into an element and adds it to cleric maces #83368
Conversation
well, there's also the disk that can print cleric maces via autolathe, and using titanium as the material gives it good AP and 7.8 hits to down iirc |
wrong pr? |
5.6 and the disk is found where the mace is |
Make the distance/speed it throws you admin editable please :) |
Does this do anything with the knockback component at all or is this separate |
there is no such thnig |
don't forget about mjollnir |
angry facef |
Mjolnir uses different, more elaborate code. I am declaring it out of scope |
it's not out of scope. |
|
Head branch was pushed to by a user without write access
/// If the throw is violent or not | ||
var/gentle = TRUE | ||
/// Callback for a proc right before confirming the attack. If it returns FALSE, cancel | ||
var/datum/callback/pre_hit_callback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to fix this or not, we already told you how on Discord
Reopen this when you want to work on it again |
About The Pull Request
Turns bat knockback into an element and adds it to cleric maces.
To farm GBP, I also turned the knockback into a standard element.
Why It's Good For The Game
Cleric maces are pretty poop. Ruin-only, bulky, and with only slightly above average damage, there's little point to hauling one around most of the time as opposed to a welding tool or something. I saw the description referenced the baseball bat, but it doesn't actually the bat's knockback gimmick, which I think would be pretty damn useful for it to be 1. less useless and 2. more useful for the space explorers that will find it.
Now it can be added to other things yayyyyyyyyy
Changelog
馃啈
refactor: Turns baseball bat knockback into an element
add: and adds it to cleric maces
/:cl: