disable client auth checks because byond is down #83435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should allow clients to auth via cached certificates without contacting byond. likely won't do anything.
|
guess we have to resort to this, any risk associated with it? |
No idea how secure the cert auth is, for admin accounts it helps that at /tg/ admins are required to auth via the forums to get admin powers, so no rce risk if somebody spoofs creds, not something downstreams will have to protect themselves with |
SirRichardFrancis
added a commit
to SirRichardFrancis/CEV-Eris
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should allow clients to auth via cached certificates without contacting byond.
likely won't do anything.lol it fucking works!About The Pull Request
Why It's Good For The Game
People being able to connect to the servers is good for the game.