-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viro Rework Tweaks (Buffed Natural Healing, Slower Progression, Stealth Respects Severity) #83459
Conversation
This reverts commit 2a78188.
This might just be anecdotal but I feel like natural immunity is already a little too strong. Yesterday I got hit with a random virus as miner containing sneezing and coughing fit, I went to the mining base and took a 5 minute pee break and by the time I was back the virus had already cured itself, the only steps I took was eating a donk pocket 20 minutes before I got the virus and having a positive moodlet from having a family heirloom. Surely we want to encourage some level of proactive behaviour on the part of players seeking to be cured? |
yeah, that's why I want to test this out more - the proactive behavior has to work though. If you'd been in low mood, starving, and hadn't stopped at any point, we'd want the virus to be able to continue. There should be a reward for having kept yourself up before getting the virus, though, and I'm happy if the result is that it pays off more for people to take care of themselves by no-selling random or invisibly-spread problems. edit: to that effect, I may look at making the mood and starvation penalties a bit harsher as well. |
Right. I ran the tests on this: https://docs.google.com/spreadsheets/d/e/2PACX-1vRuIaJdr_oP9SqRHV3jEVZe9rR6bqyyfJeoE6TbhjfUnoPIGCE952_anxWDIoh0xApkZLppRriBGdyp/pubhtml Lots of pictures and a bit of commentary to follow, but the bottom line is this: with these tweaks, you can sleep and eat to avoid viruses or cure them. Chems help, but they are not strictly necessary. Spaceacillin is good. At a baseline of mood/food and doing nothing to help yourself, it's about a coinflip still with the worst viruses - which was what I wanted to begin with. However - viruses will absolutely rock your world if you are hungry or burnt out. Take care of yourself! |
It's worth posting up - none of this is done to a degree of statistical significance or rigor you or I should accept generally. The samples are small and the trials too few to run an analysis of errors/standard deviations. This is as much as I'm willing to do with it at the moment, but I'm also very happy with the direction it points and would hope it'd get a shot. |
Also worth keeping in mind - the test viruses for AP and AN didn't have itching on them which is one of the worst low-level symptoms because of its consistent brute damage over time. These are bad, but if you look at the control values and think 'shouldn't they be deadlier?' - they can be. |
well, while virology is getting reworked, maybe there can be an admin verb to make custom viruses? |
That already exists. I forgot the name but I ran into it a few times |
yep, dead-on - there's an event for making advanced diseases |
Your Fix/Feature pull request is currently below zero (-1). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
yes and no. unless I'm missing a verb the Disease Outbreak events only really let you pick the severity and how spreadable it is, or a list of premade viruses in the case of Classic. There's no panel to make a personalized custom virus. |
## About The Pull Request #83459 made stealth a function of being equal to or higher than severity which made a lot of previously visible positive viruses hidden. Unintended behavior, fixes it. ## Why It's Good For The Game fix good, most people without HUDs can't see these anyway. It's almost a QOL thing to just be able to ask a doctor "hey do I have a positive virus" since if it's perfectly positive, there's nothing really gained by people not knowing (you, enemies, and friends alike.) ## Changelog :cl: fix: positive viruses are no longer hidden. /:cl:
…th Respects Severity) (tgstation#83459) ## About The Pull Request ![image](https://github.com/tgstation/tgstation/assets/3894717/1d041612-c364-41c7-ae4b-bd386f2acb2e) what it says on the tin. we're in virology rework season again tgstation#79854 makes natural healing enough for people to kick the teeth out of bad viruses without chem. (still needs exact testing to dial in, but ideally, chems will be a buff but no longer a mainstay. tgstation#83453 will help, and things like fungal TB will be unchanged.) makes viruses progress a bit slower across the board - this was part of why you could have a bad virus shoot up to stage 5 from having been at stage 1 out of nowhere, even after having mostly fought it off. this is probabilistic, but the prob is lower now. makes viruses only hide if their stealth stat is higher than their severity. if you want your virus to be sneaky, you need to spec into hiding it and run fewer symptoms (tgstation#83458 will fuck with this if implemented - stay tuned.) ## Why It's Good For The Game people don't like getting griefed by one-sided mechanics. while i think i got some of the way there in tgstation#79854, the felt impact of that PR was undercut by me being conservative with the values for what players' actual choices outside of chem could do and SD still existing. I'm hoping to go back and fix that first one since thankfully @Time-Green is working on tgstation#83453. Logic remains much the same as in https://hackmd.io/@Higgin/HJljdBuNp - I am leaving this as a draft until I've had at least a few more tests on the values, but I'd like to see this TM'd in a round or two with advanced diseases floating around if possible. edit to add some clarification: if you do nothing, I balanced the worst viruses to be about a 50% chance of death. if you do the right thing, it should work 100% of the time or close to it. the problem I'm trying to address here is that the second one was nowhere near 100%. ## Changelog :cl: balance: Viruses now self-heal much more effectively with good mood, sleep, food, and spaceacillin. balance: Viruses now punish being hungry more. Stay fed! balance: Spaceacillin now gives 200 ticks of symptom resistance, declining over time, rather than 100. balance: Viruses now progress slightly slower. balance: Viruses now only hide if their stealth stat is greater than their total computed severity. /:cl:
## About The Pull Request tgstation#83459 made stealth a function of being equal to or higher than severity which made a lot of previously visible positive viruses hidden. Unintended behavior, fixes it. ## Why It's Good For The Game fix good, most people without HUDs can't see these anyway. It's almost a QOL thing to just be able to ask a doctor "hey do I have a positive virus" since if it's perfectly positive, there's nothing really gained by people not knowing (you, enemies, and friends alike.) ## Changelog :cl: fix: positive viruses are no longer hidden. /:cl:
About The Pull Request
what it says on the tin. we're in virology rework season again #79854
makes natural healing enough for people to kick the teeth out of bad viruses without chem. (still needs exact testing to dial in, but ideally, chems will be a buff but no longer a mainstay. #83453 will help, and things like fungal TB will be unchanged.)
makes viruses progress a bit slower across the board - this was part of why you could have a bad virus shoot up to stage 5 from having been at stage 1 out of nowhere, even after having mostly fought it off. this is probabilistic, but the prob is lower now.
makes viruses only hide if their stealth stat is higher than their severity. if you want your virus to be sneaky, you need to spec into hiding it and run fewer symptoms (#83458 will fuck with this if implemented - stay tuned.)
Why It's Good For The Game
people don't like getting griefed by one-sided mechanics. while i think i got some of the way there in #79854, the felt impact of that PR was undercut by me being conservative with the values for what players' actual choices outside of chem could do and SD still existing. I'm hoping to go back and fix that first one since thankfully @Time-Green is working on #83453.
Logic remains much the same as in https://hackmd.io/@Higgin/HJljdBuNp - I am leaving this as a draft until I've had at least a few more tests on the values, but I'd like to see this TM'd in a round or two with advanced diseases floating around if possible.
edit to add some clarification:
if you do nothing, I balanced the worst viruses to be about a 50% chance of death.
if you do the right thing, it should work 100% of the time or close to it.
the problem I'm trying to address here is that the second one was nowhere near 100%.
Changelog
🆑
balance: Viruses now self-heal much more effectively with good mood, sleep, food, and spaceacillin.
balance: Viruses now punish being hungry more. Stay fed!
balance: Spaceacillin now gives 200 ticks of symptom resistance, declining over time, rather than 100.
balance: Viruses now progress slightly slower.
balance: Viruses now only hide if their stealth stat is greater than their total computed severity.
/:cl: