Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparks ignite flammable things (including people), welding fuel pools now ignite in response to more things logically #83673

Conversation

Metekillot
Copy link
Contributor

@Metekillot Metekillot commented Jun 3, 2024

About The Pull Request

Currently, sparks only ignite the air in rooms with plasma/tritium/hydrogen in them. This PR changes sparks to ignite flammable things they touch, including mobs covered in flammable liquids. They also marginally heat containers (40K temp increase from a broken light bulb).

The initial purpose was to make welding fuel pools more responsive to flaming things being thrown into them. I have also done that. They now respond to hot objects (including flaming mobs) entering their space or being thrown onto them. They are also ignited by sparks.

This PR makes sparks a fire hazard. Keep a fire extinguisher handy.

Why It's Good For The Game

Safety hazards are fun. Sparks should, logically, set flammable things on fire, including YOU. Welding fuel pools should be more hazardous.

Changelog

🆑 Bisar
add: Sparks now ignite flammable things. Including you. Keep a fire extinguisher handy or stop dousing yourself in welding fuel!
fix: Fixed a few oversights with welding fuel pools not igniting when you throw lit/hot things into them or when you walk into them while on fire.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances labels Jun 3, 2024
@Admiral-Gigaton
Copy link

Hey boss, can you make melee-ing someone doused in flammable shit, while welding an open flames object (eg. A lighter) sets them on fire? Works with PR

@Metekillot
Copy link
Contributor Author

Pretty sure that already happens.

@Metekillot Metekillot force-pushed the sparks-ignite-flammables-+-welding-fuel-pools-more-responsive branch from 5f6ee9b to 1d84224 Compare June 3, 2024 02:27
@Mothblocks Mothblocks marked this pull request as draft June 3, 2024 02:41
@Bibarra
Copy link

Bibarra commented Jun 3, 2024

Would that include things like cigarettes/cigars?

@Metekillot
Copy link
Contributor Author

Would that include things like cigarettes/cigars?

Yes

@Metekillot Metekillot marked this pull request as ready for review June 3, 2024 06:14
@Metekillot Metekillot force-pushed the sparks-ignite-flammables-+-welding-fuel-pools-more-responsive branch from 8faf753 to cdaaa4b Compare June 3, 2024 07:55
@Loafin34
Copy link
Contributor

Loafin34 commented Jun 4, 2024

Just for clarification, this will affect people who are coated with a flammable liquid, not everyone, right? it might screw with people if the RPD sparking sets them on fire in a regular environment.

@Metekillot
Copy link
Contributor Author

Screenshot_20240604_014115_GitHub.jpg

@Constellado
Copy link
Contributor

Does this affect welding tanks? Or just fuel pools?

@Metekillot
Copy link
Contributor Author

Metekillot commented Jun 4, 2024

Just pools

EDIT: Specifically, the welding fuel in the tank will be heated, but the logic for exploding welding tanks is handled by bespoke procs and the fire_act proc.

Fire_act is called when something is, naturally, inside an active fire. Sparks call fire_act, but only on children of obj/ with the FLAMMABLE bit flag for their var/resistance_flags. Welding tanks are not FLAMMABLE when it comes to their resistance flags, so sparks won't explode them

@lessthnthree
Copy link
Contributor

lessthnthree commented Jun 5, 2024

Just for clarification, this will affect people who are coated with a flammable liquid, not everyone, right? it might screw with people if the RPD sparking sets them on fire in a regular environment.

Only if the person has flammable liquid.

Regular RPD usage, safe.
Dousing yourself with welding fuel, then using the RPD, not so safe.

Same safety rule as 'Don't use the RPD in a room with a plasma leak'

…it didn't take them upstream for whatever reason
@Metekillot Metekillot force-pushed the sparks-ignite-flammables-+-welding-fuel-pools-more-responsive branch from a71b13a to 4410bac Compare June 15, 2024 20:56
…sparks-ignite-flammables-+-welding-fuel-pools-more-responsive
@Deultus
Copy link

Deultus commented Jul 5, 2024

It made the game worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants