-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparks ignite flammable things (including people), welding fuel pools now ignite in response to more things logically #83673
Conversation
…rom having hot items (or people) put in them
…light-fuel-pools
…se to things more logically
Hey boss, can you make melee-ing someone doused in flammable shit, while welding an open flames object (eg. A lighter) sets them on fire? Works with PR |
Pretty sure that already happens. |
5f6ee9b
to
1d84224
Compare
Would that include things like cigarettes/cigars? |
Yes |
8faf753
to
cdaaa4b
Compare
Just for clarification, this will affect people who are coated with a flammable liquid, not everyone, right? it might screw with people if the RPD sparking sets them on fire in a regular environment. |
Does this affect welding tanks? Or just fuel pools? |
Just pools EDIT: Specifically, the welding fuel in the tank will be heated, but the logic for exploding welding tanks is handled by bespoke procs and the fire_act proc. Fire_act is called when something is, naturally, inside an active fire. Sparks call fire_act, but only on children of obj/ with the FLAMMABLE bit flag for their var/resistance_flags. Welding tanks are not FLAMMABLE when it comes to their resistance flags, so sparks won't explode them |
Only if the person has flammable liquid. Regular RPD usage, safe. Same safety rule as 'Don't use the RPD in a room with a plasma leak' |
… up the var names even more
…ily); we'll just set the fire damage extremely low
…it didn't take them upstream for whatever reason
a71b13a
to
4410bac
Compare
…sparks-ignite-flammables-+-welding-fuel-pools-more-responsive
…ng-fuel-pools-more-responsive
…onsive' of https://github.com/Metekillot/tgstation into sparks-ignite-flammables-+-welding-fuel-pools-more-responsive
It made the game worse |
About The Pull Request
Currently, sparks only ignite the air in rooms with plasma/tritium/hydrogen in them. This PR changes sparks to ignite flammable things they touch, including mobs covered in flammable liquids. They also marginally heat containers (40K temp increase from a broken light bulb).
The initial purpose was to make welding fuel pools more responsive to flaming things being thrown into them. I have also done that. They now respond to hot objects (including flaming mobs) entering their space or being thrown onto them. They are also ignited by sparks.
This PR makes sparks a fire hazard. Keep a fire extinguisher handy.
Why It's Good For The Game
Safety hazards are fun. Sparks should, logically, set flammable things on fire, including YOU. Welding fuel pools should be more hazardous.
Changelog
🆑 Bisar
add: Sparks now ignite flammable things. Including you. Keep a fire extinguisher handy or stop dousing yourself in welding fuel!
fix: Fixed a few oversights with welding fuel pools not igniting when you throw lit/hot things into them or when you walk into them while on fire.
/:cl: