Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some logging to roundstart, to figure out why it's been taking longer recently #83745

Closed

Conversation

GoldenAlpharex
Copy link
Contributor

About The Pull Request

Spiritual continuation of #69366. I've noticed some slowdowns, recently, and hopefully this helps us figure it out.

Why It's Good For The Game

Speeding up the start of the game is a good thing, methinks.

Changelog

This should probably not be merged? I don't know, it could be good I suppose, but that's going to be up to Lemon to decide, not me.

@tgstation-server tgstation-server added the Logging printf("Here"); printf("Here2"); printf("Heree"); label Jun 5, 2024
@MrMelbert MrMelbert added the Test Merge Only I'm too scared to suggest this as a real change. label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request was test merged in 147 round(s).

Round list

manuel

terry

@Sadboysuss
Copy link
Contributor

Nuclear operatives always delay the round, may be useful

@ZephyrTFA
Copy link
Contributor

Nuclear operatives always delay the round, may be useful

they delay the round because lazy loading is being waited for instead of actually being lazy loaded

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Jun 19, 2024
@san7890
Copy link
Member

san7890 commented Jun 19, 2024

closed PRs can be test merged, no reason for this to be open and clog the tracker.

@san7890 san7890 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logging printf("Here"); printf("Here2"); printf("Heree"); Stale Even the uncaring universe rejects you, why even go on Test Merge Only I'm too scared to suggest this as a real change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants