Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power cell tiers consistency #84074

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Power cell tiers consistency #84074

merged 4 commits into from
Jun 19, 2024

Conversation

MTandi
Copy link
Contributor

@MTandi MTandi commented Jun 17, 2024

About The Pull Request

Tier 3 had both 20 and 30 MJ cells for some reason, while 10 MJ cell was considered tier 2.

Now the scaling is proper: 10 MJ is tier 1, 20 MJ is tier 2, and so on...

Also updated plasma crystal sprite, and gave unique sprites to the smallest cells.

image

Why It's Good For The Game

The scaling was off, and the sprites made them look out of place for their tier.

Changelog

🆑
fix: Made 10 MJ & 20 MJ cells properly correspond to tiers 1 & 2 in lathes.
image: Updated cell sprites to correspond to other stock parts of their tiers.
image: Updated plasma cell, 500KJ cell and 2.5MJ cell sprites
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Fix Rewrites a bug so it appears in different circumstances labels Jun 17, 2024
@MTandi MTandi marked this pull request as draft June 17, 2024 21:50
@MTandi
Copy link
Contributor Author

MTandi commented Jun 17, 2024

I'll add a couple more sprites.

@alien3301
Copy link
Contributor

I feel like the tier 3 cell should keep that gold line. Makes it more consistent with the other cells.

@MTandi MTandi requested a review from Wallemations June 17, 2024 22:36
@MTandi MTandi marked this pull request as ready for review June 17, 2024 22:36
@EricZilla
Copy link
Contributor

Those lil batteries are to die for. Is the 2.5 meant to be a double battery or a D battery?

@AarontheIdiot
Copy link
Contributor

t1 and t2 cells would look too similar at a glance imo

@MTandi
Copy link
Contributor Author

MTandi commented Jun 18, 2024

Those lil batteries are to die for. Is the 2.5 meant to be a double battery or a D battery?

Double, 9V. I initialy thought of making it for 1 MJ variant, but it seems to be a default one for many cells in the game.

@MTandi
Copy link
Contributor Author

MTandi commented Jun 18, 2024

t1 and t2 cells would look too similar at a glance imo

Not much different from the matter bins on the side as you can see, thanks to orange being bright and the red being dark.
In-game it looks good to me.

@MTandi
Copy link
Contributor Author

MTandi commented Jun 18, 2024

I feel like the tier 3 cell should keep that gold line. Makes it more consistent with the other cells.

The other parts don't have any orange lines.

image

san7890

This comment was marked as outdated.

@san7890 san7890 self-requested a review June 18, 2024 23:19
Copy link
Member

@san7890 san7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay code is actually fine

@Admiral-Gigaton
Copy link

Plasma crystal be summoning queen slime rn

@ZephyrTFA ZephyrTFA merged commit f5f9c5b into tgstation:master Jun 19, 2024
20 checks passed
comfyorange added a commit that referenced this pull request Jun 19, 2024
github-actions bot added a commit that referenced this pull request Jun 19, 2024
@xXPawnStarrXx
Copy link
Contributor

xXPawnStarrXx commented Jun 19, 2024

I feel like the tier 3 cell should keep that gold line. Makes it more consistent with the other cells.

The other parts don't have any orange lines.

Maybe add that cream colour as a line so it keeps the same pattern as it's tier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants