Skip to content

Commit

Permalink
Fix the misconfigured base url env var (#178)
Browse files Browse the repository at this point in the history
* Fix the misconfigured base url env var

* Fix tests

* Fix tests

* Fix tests
  • Loading branch information
th0th committed May 1, 2023
1 parent 00d8f8d commit e81fa16
Show file tree
Hide file tree
Showing 23 changed files with 333 additions and 341 deletions.
1 change: 1 addition & 0 deletions .idea/runConfigurations/_template__of_Go_Test.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/browsername/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func TestGet(t *testing.T) {
}

if filteredTestData[i].VisitorCount == filteredTestData[j].VisitorCount {
return *filteredTestData[i].BrowserName > *filteredTestData[j].BrowserName
return *filteredTestData[i].BrowserName < *filteredTestData[j].BrowserName
}

return false
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/browserversion/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func Get(dp *depot.Depot, filters *filter.Filters, paginationCursor *PaginationC

totalVisitorCountSubQuery := baseQuery.
Session(&gorm.Session{}).
Select("count(distinct visitor_id) as count")
Select("count(distinct visitor_id)")

baseSubQuery := baseQuery.
Session(&gorm.Session{}).
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/browserversion/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestGet(t *testing.T) {
}

if filteredTestData[i].VisitorCount == filteredTestData[j].VisitorCount {
return *filteredTestData[i].BrowserVersion > *filteredTestData[j].BrowserVersion
return *filteredTestData[i].BrowserVersion < *filteredTestData[j].BrowserVersion
}

return false
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/country/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func TestGet(t *testing.T) {
}

if testData[i].VisitorCount == testData[j].VisitorCount {
return testData[i].CountryIsoCode > testData[j].CountryIsoCode
return testData[i].CountryIsoCode < testData[j].CountryIsoCode
}

return false
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/language/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func TestGet(t *testing.T) {
}

if filteredTestData[i].VisitorCount == filteredTestData[j].VisitorCount {
return *filteredTestData[i].Language > *filteredTestData[j].Language
return *filteredTestData[i].Language < *filteredTestData[j].Language
}

return false
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/service/sitereport/operatingsystemname/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func Get(dp *depot.Depot, filters *filter.Filters, paginationCursor *PaginationC

totalVisitorCountSubQuery := baseQuery.
Session(&gorm.Session{}).
Select("count(distinct visitor_id) as count")
Select("count(distinct visitor_id)")

baseSubQuery := baseQuery.
Session(&gorm.Session{}).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func TestGet(t *testing.T) {
}

if filteredTestData[i].VisitorCount == filteredTestData[j].VisitorCount {
return *filteredTestData[i].OperatingSystemName > *filteredTestData[j].OperatingSystemName
return *filteredTestData[i].OperatingSystemName < *filteredTestData[j].OperatingSystemName
}

return false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func Get(dp *depot.Depot, filters *filter.Filters, paginationCursor *PaginationC

totalVisitorCountSubQuery := baseQuery.
Session(&gorm.Session{}).
Select("count(distinct visitor_id) as count")
Select("count(distinct visitor_id)")

baseSubQuery := baseQuery.
Session(&gorm.Session{}).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestGet(t *testing.T) {
}

if filteredTestData[i].VisitorCount == filteredTestData[j].VisitorCount {
return *filteredTestData[i].OperatingSystemVersion > *filteredTestData[j].OperatingSystemVersion
return *filteredTestData[i].OperatingSystemVersion < *filteredTestData[j].OperatingSystemVersion
}

return false
Expand Down
Loading

0 comments on commit e81fa16

Please sign in to comment.