add define_step and steps and calculate steps prefix length dynamically #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # def ButThen(msg, &block) | ||
| # step(" But Then #{msg}", &block) | ||
| # end | ||
| define_step(*%w[Given When Then And But]) |
| if | ||
| msg.is_a? Array | ||
| then | ||
| prefix, text = msg |
There was a problem hiding this comment.
is there a case where msg would not be an array? maybe we should just have it as:
example.metadata[:bdd_step_messages].map do |prefix, text|and we get rid of the extra if that clutters the code :)
There was a problem hiding this comment.
no, msg will always be an Array, originally the code was longer and the prefix did not come with the msg.
Now, always array.
mpapis
force-pushed
the
feature/improved_formating
branch
from
92c0c81
to
2c07ab3
Compare
| @@ -81,4 +81,7 @@ def run_test(name) | |||
| expect(@test.failures.count).to eq(1) | |||
| end | |||
|
|
|||
| def uncolorize(text) | |||
There was a problem hiding this comment.
I wonder if this should go to Bdd::Colors?
Closed
| # def ButThen(msg, &block) | ||
| # step(" But Then #{msg}", &block) | ||
| # end | ||
| define_bdd_step(*%w[Given When Then And But]) |
| And("a condition Y") {} | ||
| And("a condition Y") { | ||
| Then("overwrite happened") { | ||
| But("it did nothing") |
There was a problem hiding this comment.
this was showing SKIPPED without indentation after a condition Y - it's fixed now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a bit more magic :D