transport protocol support #18
Conversation
| @@ -29,8 +29,9 @@ import java.nio.file.Path | |||
| @AutoService(IPipelineCodecFactory::class) | |||
| class XmlPipelineCodecFactory : IPipelineCodecFactory { | |||
| override val settingsClass: Class<out IPipelineCodecSettings> = XmlPipelineCodecSettings::class.java | |||
| @Deprecated("Please migrate to the protocols property") | |||
| override val protocol: String = PROTOCOL | |||
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Please, add jvm target for kotlin tasks - there is a warning during compilation
'compileTestJava' task (current target is 11) and 'kaptGenerateStubsTestKotlin' task (current target is 1.8) jvm target compatibility should be set to the same Java version.
build.gradle
Outdated
| @@ -164,11 +150,39 @@ compileTestKotlin { | |||
| } | |||
| } | |||
|
|
|||
| clean { | |||
| clean {+6 | |||
| val map = message.body | ||
| val xmlString = Xml.toXml(map) | ||
|
|
||
| validator.validate(xmlString.toByteArray()) |
There was a problem hiding this comment.
I think we can (and should) reuse this buffer when creating RawMessage below. Also, we must use correct charset when converting string to bytes
| eventId = message.eventId, | ||
| metadata = message.metadata, | ||
| protocol = XmlPipelineCodecFactory.PROTOCOL, | ||
| body = Unpooled.copiedBuffer(xmlString, xmlCharset) |
There was a problem hiding this comment.
Do we need to copy the result bytes? I think we can wrap the bytes that we used for validator.validate method call
build.gradle
Outdated
| testImplementation "org.junit.jupiter:junit-jupiter-api:$junitVersion" | ||
| testImplementation "org.junit.jupiter:junit-jupiter-params:$junitVersion" | ||
| testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junitVersion" |
There was a problem hiding this comment.
This all can be replaced with
| testImplementation "org.junit.jupiter:junit-jupiter-api:$junitVersion" | |
| testImplementation "org.junit.jupiter:junit-jupiter-params:$junitVersion" | |
| testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junitVersion" | |
| testImplementation "org.junit.jupiter:junit-jupiter:$junitVersion" |
| testImplementation "org.junit.jupiter:junit-jupiter-api:$junitVersion" | ||
| testImplementation "org.junit.jupiter:junit-jupiter-params:$junitVersion" | ||
| testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junitVersion" |
There was a problem hiding this comment.
Why have you removed all these dependencies? kotlin-test-junit5 does provide junit-jupiter-api and junit-jupiter-engine but it does not provide junit-jupiter-params
There was a problem hiding this comment.
Probably junit-jupiter-params is not used in this project. Compilation succeed and all tests are passed. So we don't need this dependency.
No description provided.