build(deps): bump softprops/action-gh-release from 1 to 2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@de2c0eb...3198ee1) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The following labels could not be found: |
|
Looks like softprops/action-gh-release is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/github_actions/softprops/action-gh-release-2
branch
thaJeztah
added a commit
that referenced
this pull request
May 17, 2024
I was trying to run a build stage as non-root user, but it uses some cache
mounts. So I tried to mount the cache-mount with a specific group (gid), and
set permissions to 0775 (instead of the default 0755) to allow the stage to
write, but it looks like it still ends up with 0755 permissions.
Most minimal reproducer;
docker build --progress=plain --no-cache -<<'EOF'
# syntax=docker/dockerfile:1
FROM alpine
RUN --mount=type=cache,target=/hello/.cache,mode=0775 ls -la /hello/.cache/
Which shows that the target has 0755 permissions;
#6 [stage-0 1/2] FROM docker.io/library/alpine:latest
#6 DONE 0.0s
#7 [internal] settings cache mount permissions
#7 DONE 0.1s
#8 [stage-0 2/2] RUN --mount=type=cache,target=/hello/.cache,mode=0775 ls -la /hello/.cache/
#8 0.641 total 8
#8 0.641 drwxr-xr-x 2 root root 4096 May 17 12:04 .
#8 0.641 drwxr-xr-x 3 root root 4096 May 17 12:04 ..
#8 DONE 0.7s
Looking at that `settings cache mount permissions` message brings me to this
code, which uses `llb.Mkdir`;
https://github.com/moby/buildkit/blob/4b5bf7ef9b3cd0a2485c173f0700dce21e83d964/frontend/dockerfile/dockerfile2llb/convert_runmount.go#L60
My initial assumption is that possibly the given filemode still gets an umask
applied, causing the effective permissions to be different.
It's a bit hard to find where the actual `Mkdir` happens, because that function
returns a `FileOp` (which only contains the options), but looking through tests
I see that there's various tests setting a mode, but all of them seem to use
a mode that's not affected by umask (assuming default `022` umask); most (if
not "all") of them seem to be using (e.g.) `0700` or `0600`.
Let's change a test to see if it fails, which may confirm my suspicion.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps softprops/action-gh-release from 1 to 2.
Release notes
Sourced from softprops/action-gh-release's releases.
Changelog
Sourced from softprops/action-gh-release's changelog.
... (truncated)
Commits
3198ee1prep release7ee8e06declare an update docs for make_latest input (#419)d99959eprep release0e39c67make pattern error opt in (#417)20e085ckick off 2.0.1 release9f5c4d3update changelog0bea76bAdd support for make_latest property (#304)762fe13typo in changelogc0f2569remove unused script5743e06update changelogDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)