Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate imports while parsing #11

Closed
Fxhnd opened this issue Oct 12, 2017 · 1 comment
Closed

Handle duplicate imports while parsing #11

Fxhnd opened this issue Oct 12, 2017 · 1 comment

Comments

@Fxhnd
Copy link
Collaborator

Fxhnd commented Oct 12, 2017

At the current moment the Parser works overtime because no effort is made to reuse already tokenized/parsed files. Speed-wise it's still faster than the previous implementation (can tokenize/parse/import all of voids_extended.clif in under 8 seconds with output) even with the multitude of duplicate imports.

Don't know the exact way forward here, but marking it down so we're aware.

@thahmann
Copy link
Owner

thahmann commented Feb 5, 2021

Believe it is fixed with the latest updated to Ontology.resolve_imports()

@thahmann thahmann closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants