Python backend #1
Conversation
Simplify config and port setup
|
Hi @fdegier thanks for the help! I'll test the changes and get back over the weekend. |
python_backend/init_model.py
Outdated
| with open(os.path.join(model_dir_path, '../config.pbtxt'), 'w') as f: | ||
| f.write(config) | ||
| print(f"Config written to") |
There was a problem hiding this comment.
Minor: Seems incomplete
There was a problem hiding this comment.
The python script was running so fast, I thought it was not being called so I added a print statement and indeed its incomplete. Would it make sense to add a print statement here to notify users that it ran successfully?
setup.sh
Outdated
|
|
||
| # Write .env | ||
| echo "NUM_GPUS=${NUM_GPUS}" >> .env | ||
| echo "MODEL_DIR=${MODEL_DIR}/${MODEL}-${NUM_GPUS}gpu" >> .env |
There was a problem hiding this comment.
MODEL is initialized later, which makes this line output "MODEL_DIR=.../models/-1gpu".
I think the config should be written in a separate function because the model dir format is different depending upon the backend.
|
Hi @fdegier I noticed some issues with setup.py while testing the changes. It's mostly related to adding stuff to the .env file. I'll take a stab at the changes and might ask you to test them out if possible |
|
Interesting, for me all manual test cases worked. Which OS are you on? I will be online again on Monday. |
|
I'm using Linux via WSL.
If you see here, MODEL isn't initialized here (it's initialized inside the backend functions). As a result, MODEL_DIR is not set correctly. This issue didn't arise in your original PR to moyix's repo because MODEL was initialized over there:
Weirdly, I'm unable to locate the commit where the MODEL assignment was removed but I'm guessing it got lost in the merge conflict resolution. |
Hi @thakkarparth007 👋
I like your PR a lot, yesterday I introduced quite a few changes so I helped you resolve the conflicts. I also ran into a few issues with the setup script which I fixed, can you do some testing? In fauxpilot#86 I've left additional comments.