fix: undefined txid length (#12)

thalesog · Aug 28, 2022 · 25b5624 · 25b5624
1 parent a8e50d3
commit 25b5624
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/create.ts b/src/create.ts
@@ -61,7 +61,7 @@ export function createStaticPix(
       },
     };
 
-  if (params.txid.length > 25)
+  if (params.txid && params.txid.length > 25)
     return {
       error: true,
       message: 'txid character limit exceeded (> 25)',

diff --git a/tests/creator.test.ts b/tests/creator.test.ts
@@ -8,6 +8,21 @@ import {
 
 describe('EMV Code Creation', () => {
   it('should be able to create a static pix from mandatory fields', () => {
+    const staticPixFn = createStaticPix({
+      merchantName: 'Thales Ogliari',
+      merchantCity: 'SAO MIGUEL DO OESTE'.substr(0, 15),
+      pixKey: 'thalesog@me.com',
+      infoAdicional: 'Pedido 123',
+      transactionAmount: 10,
+    });
+
+    expect(hasError(staticPixFn)).toBe(false);
+    if (hasError(staticPixFn)) return;
+
+    expect(staticPixFn.toBRCode()).toBe(STATIC_TEST_EMV);
+  });
+
+  it('should be able to create a static pix from mandatory fields and empty txid', () => {
     const staticPixFn = createStaticPix({
       merchantName: 'Thales Ogliari',
       merchantCity: 'SAO MIGUEL DO OESTE'.substr(0, 15),
@@ -23,7 +38,7 @@ describe('EMV Code Creation', () => {
     expect(staticPixFn.toBRCode()).toBe(STATIC_TEST_EMV);
   });
 
-  it('should be able to create a static pix from mandatory fields with no value', () => {
+  it('should be able to create a static pix from mandatory fields with no amount defined', () => {
     const staticPixFn = createStaticPix({
       merchantName: 'Thales Ogliari',
       merchantCity: 'SAO MIGUEL DO OESTE'.substr(0, 15),