jwt::verifier<jwt::default_clock>::algo_base::~algo_base() unresolved reference

[p4w4n]

Hey,

Thanks for the great library. However when I am trying to compile the code I am getting an unresolved reference for jwt::verifierjwt::default_clock::algo_base::~algo_base().

Error: unresolved references found.
jwt::verifierjwt::default_clock::algo_base::~algo_base()

Can you please help.

Thanks a lot!!!

[Thalhammer]

What compiler/OS are you using?
Any special compiler flags?

[p4w4n]

cpp --version
cpp (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)

[Thalhammer]

Do you get the error when trying to compile the test cases?
gcc 4.8.5 is pretty old, make sure you compile with -std=c++11

[p4w4n]

Yes, I get this while compiling the test cases and/or with my own code where I am calling jwt decode. I am actually working on a legacy system and looks like it doesn't support c++11(it does support c++0x). When I commented out the virtual ~algo_base(), the unresolved reference went away. Do you think commenting out the virtual destructor will have and adverse effect?

…

On Fri, Apr 19, 2019 at 3:16 AM Dominik Thalhammer ***@***.***> wrote: Do you get the error when trying to compile the test cases? gcc 4.8.5 is pretty old, make sure you compile with -std=c++11 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEV43XQVNJZKU3YDGI6L4KLPRDT2DANCNFSM4HHANC2A> .

[Thalhammer]

Do you think commenting out the virtual destructor will have and adverse effect?

Yes absolutely. The virtual destructor is needed to allow the algorithm to be destroyed. If you remove it you WILL leak memory everytime you create/destory a verifier.

You can try replacing the line

virtual ~algo_base() = default;

with

virtual ~algo_base() {}

This might fix it, if it compiles fine otherwise.

[p4w4n]

Do you think commenting out the virtual destructor will have and adverse effect?

Yes absolutely. The virtual destructor is needed to allow the algorithm to be destroyed. If you remove it you WILL leak memory everytime you create/destory a verifier.

You can try replacing the line

virtual ~algo_base() = default;

with

virtual ~algo_base() {}

This might fix it, if it compiles fine otherwise.

Thanks a lot!!! Converting it to a function resolved the issue. :)