Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Thalitest specific files #23

Closed
yaronyg opened this issue Jul 9, 2015 · 2 comments
Closed

Remove the Thalitest specific files #23

yaronyg opened this issue Jul 9, 2015 · 2 comments

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Jul 9, 2015

Right now we use app.js and the root package.json and index.html and a bunch of other files that we require to be moved over to whatever project is using us. But in the process we actually overwrite the files in the project that is using us. After all, that project will have its own index.html and its own package.json and its own app.js.

What we need to do is remove all the Thalitest specific files and we need to format our JS code so that it is a NPM module that the user can then require().

@obastemur
Copy link
Contributor

@obastemur obastemur commented Jul 9, 2015

Agree. Also, you better block 'thali' npm name as soon as possible.

@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Jul 9, 2015

@yaronyg yaronyg closed this Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.