Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open_account should check initial_balance for Negative Or Zero Amount as well #2

Closed
omac777 opened this issue Jan 25, 2022 · 2 comments
Closed

open_account should check initial_balance for Negative Or Zero Amount as well #2

omac777 opened this issue Jan 25, 2022 · 2 comments

Comments

@omac777
Copy link

omac777 commented Jan 25, 2022

I looked at the example. It's straightforward. Well done. In bank_account.rs, I noticed you did some Negative or Zero Amount checks for withdraw and deposit, but I believe you should be doing the same for open_account as well. Thank you.
@tqwewe
Copy link
Member

tqwewe commented Jan 25, 2022

Ah good catch, thats true!

tqwewe added a commit that referenced this issue Jan 25, 2022
@tqwewe
test(examples/bank-account): add missing negative check for open account
9ce356a 
Closes #2
@tqwewe
Copy link
Member

tqwewe commented Jan 25, 2022

Fixed in 9ce356a 👍

@tqwewe tqwewe closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omac777 @tqwewe