Source holidays from user's location

[tupaschoal]

It would be great if the users could type in their locations and the calendar would adapt accordingly including holidays.
There are several ways to make this more complex

• Start with just a country
• Move to city-based
• Make app read approximate location, instead of having user type it

[tupaschoal]

Seems like sourcing it from the location might be difficult, but I found some resources on where to get the holidays from.

There's this date-holidays module and it even has an html example which can probably be used as inspiration on how to make a list of checkboxes in the configuration to choose from.

[thamara]

I'm currently working on this and would like some feedback on the flow I'm implementing. @tupaschoal and @araujoarthur0 can you please share some thoughts on this?

Basically I'm adding a tab on Workday Waiver called Holiday. In it, the user selects the year, country, state, and city (if available). All the holidays matching that are displayed automatically bellow, with some columns to indicate if that's on a working day if there's any conflict with any previously added waiver. There's also a select button that is enabled if there's no conflict and if the holiday is on a working day. The user can select which holidays to the source, and click the button below, which will add the holidays.

Here's a gif of that in action:

[araujoarthur0]

I think that looks wonderful. The conflict feature is even more than I expected :)

[tupaschoal]

It looks brilliant. I have a few comments and questions:

1. What happens if you choose to add a holiday on a day that has a conflict? Does it override the previous entry or just fails silently?
2. What happens if you choose to add a holiday on a day that is a non working day? It just fails silently?
3. Do we remember the last location set by the user? If not, I think it would be a nice to have, so that they don't have to select country/state/city every time they want to source it (though arguably it would be once a year).

[thamara]

What happens if you choose to add a holiday on a day that has a conflict? Does it override the previous entry or just fails silently?

It overrides the previous entry.

What happens if you choose to add a holiday on a day that is a non working day? It just fails silently?

Just adds it anyway, but this entry is not used by the app.

Do we remember the last location set by the user? If not, I think it would be a nice to have, so that they don't have to select country/state/city every time they want to source it (though arguably it would be once a year).

For now, it doesn't. I have thought about "inferring" the user location based on geolocalization, but I could not find a good (and light) library for this. This could be an enhancement in the future.

For the 2 first topics, I think I can create a warning message, or confirmation box informing this to the user. Let me work on this tonight and I'll update you. The 3rd one is a bit trickier and I would like to avoid having to store it somewhere in the tool for now. I prefer to do some more research and offer an even better solution (automatic identifying the user location).

Another enhancement I can see is to allow the user to customize the waiver hours from the table of of holidays to be sourced. But again, I think this one should be done later.

[tupaschoal]

I think we're alright with them overwriting for now, pop-up may be a bit distracting.

As for saving the location, like I said, it's a nice to have to avoid a few clicks once a year (potentially)