Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count Today in Totals is breaking the month balance #229

Closed
araujoarthur0 opened this issue May 15, 2020 · 1 comment
Closed

Count Today in Totals is breaking the month balance #229

araujoarthur0 opened this issue May 15, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
When disabling the "Count Today in Totals" preference, the actual day is not being counted anymore, but the missing balance of the other days is entering the total calculation.

To Reproduce
Steps to reproduce the behavior:

  1. Click on Edit
  2. Open Preferences
  3. Switch off "Count Today in Totals"
  4. You will see your month balance go into the negatives if there are unfilled days in the month.

Expected behavior
I expected the count total to simply stop calculating on the previous day, not for it ignore the current day and start counting the following unfilled ones.

Environment

  • Node/npm version: Node v10.20.1 / npm 6.9.0
  • OS: Windows 10
  • TTL version: master

Screenshots
counttoday

Additional context
I see the actual issue is that there used to be a break in the code that stopped month balance calculation, and it's now being avoided when you set the setting to off.

@araujoarthur0 araujoarthur0 added the bug Something isn't working label May 15, 2020
@araujoarthur0
Copy link
Collaborator Author

I'm working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant