Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiver deletion doesn't allow new waivers. #240

Closed
araujoarthur0 opened this issue May 23, 2020 · 7 comments
Closed

Waiver deletion doesn't allow new waivers. #240

araujoarthur0 opened this issue May 23, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
When removing a waiver, it's not possible to add a new one without closing the window.

To Reproduce
Steps to reproduce the behavior:

  1. Remove waiver.
  2. Try to add a new one.

Expected behavior
After removing you should then be able to add new ones.

Environment
Version: 1.5.2-dev
Electron: 7.1.13
Chrome: 78.0.3904.130
Node.js: 12.8.1
OS: Windows_NT x64 10.0.17763

Screenshots
waiver

@araujoarthur0 araujoarthur0 added the bug Something isn't working label May 23, 2020
@thamara
Copy link
Owner

thamara commented May 26, 2020

@araujoarthur0 In order to be able to add a waiver one must input the "Reason". Without it the Waive button is not enabled.
From the gif I didn't see the input being entered.
I tried to reproduce here and could not see any problem.

@araujoarthur0
Copy link
Collaborator Author

After pressing delete, the inputs became "uneditable", so I couldn't input a new reason. Are you on mac? Could it be a Windows-only issue?

@tupaschoal
Copy link
Collaborator

I think I also reproduced it on windows

@thamara
Copy link
Owner

thamara commented May 26, 2020

Yeah, I'm on mac and could not see the problem. Can you please check the developer log to see if any error message is being printed?

@araujoarthur0
Copy link
Collaborator Author

Nothing appeared on the log. However it looks like the inputs become selectable again after switching windows, without closing.

@araujoarthur0
Copy link
Collaborator Author

araujoarthur0 commented May 27, 2020

@tupaschoal
Copy link
Collaborator

Done

araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 30, 2020
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue May 31, 2020
tupaschoal added a commit that referenced this issue May 31, 2020
Fix #240: waiver using electron dialog instead of js confirm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants