-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waiver deletion doesn't allow new waivers. #240
Comments
@araujoarthur0 In order to be able to add a waiver one must input the "Reason". Without it the Waive button is not enabled. |
After pressing delete, the inputs became "uneditable", so I couldn't input a new reason. Are you on mac? Could it be a Windows-only issue? |
I think I also reproduced it on windows |
Yeah, I'm on mac and could not see the problem. Can you please check the developer log to see if any error message is being printed? |
Nothing appeared on the log. However it looks like the inputs become selectable again after switching windows, without closing. |
Found it: https://stackoverflow.com/questions/56805920/cant-edit-input-text-field-after-window-alert |
Done |
Fix #240: waiver using electron dialog instead of js confirm
Describe the issue
When removing a waiver, it's not possible to add a new one without closing the window.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
After removing you should then be able to add new ones.
Environment
Version: 1.5.2-dev
Electron: 7.1.13
Chrome: 78.0.3904.130
Node.js: 12.8.1
OS: Windows_NT x64 10.0.17763
Screenshots
The text was updated successfully, but these errors were encountered: