Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow adding waivers to non-working day #250

Closed
tupaschoal opened this issue May 31, 2020 · 0 comments
Closed

Don't allow adding waivers to non-working day #250

tupaschoal opened this issue May 31, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@tupaschoal
Copy link
Collaborator

Describe the current limitation
If you try to add a waiver to a non working day, currently, it fails silently, neither adding it nor telling you that it can't be done.

Describe the proposed feature or enhancement
I think we should pop-up, like when we try to a day that already exists or an end date before the start date
@tupaschoal tupaschoal added the enhancement New feature or request label May 31, 2020
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue May 31, 2020
@tupaschoal
Fix thamara#250: Don't allow waiver to be added to non-working day
8915002
@tupaschoal tupaschoal mentioned this issue May 31, 2020
Merged
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue May 31, 2020
@tupaschoal
Fix thamara#250: Don't allow waiver to be added to non-working day
700ed75
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue May 31, 2020
@tupaschoal
Fix thamara#250: Waiver can be added to non-working day/range
262a0e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tupaschoal