Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the preferences window without changing anything causes an exception #255

Closed
araujoarthur0 opened this issue May 31, 2020 · 2 comments · Fixed by #261
Closed

Closing the preferences window without changing anything causes an exception #255

araujoarthur0 opened this issue May 31, 2020 · 2 comments · Fixed by #261
Labels
bug Something isn't working

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
A clear and concise description of what the issue is.

Closing the preferences window without changing anything causes an exception

To Reproduce
Steps to reproduce the behavior:

  1. Go to Edit
  2. Click on Preferences
  3. Close without saving
  4. See error

image

Expected behavior
A clear and concise description of what you expected to happen.

No error

Environment

Version: 1.5.2-dev
Electron: 9.0.0
Chrome: 83.0.4103.64
Node.js: 12.14.1
OS: Windows_NT x64 10.0.17763

Additional context
Add any other context about the problem here.

The issue is how the preferences window "onClose" event is set. It goes to save the contents of "savedPreferences", but that is only filled if something is changed in the preferences window.
"null" is saved then, and all is broken.
@araujoarthur0 araujoarthur0 added the bug Something isn't working label May 31, 2020
@tupaschoal
Copy link
Collaborator

I thought this would have been fixed by #249 😭

@araujoarthur0
Copy link
Collaborator Author

Apparently there were two different issues heuahea

araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Jun 4, 2020
@araujoarthur0
Fix thamara#255: avoiding preferences save when still null
5e13006
@araujoarthur0 araujoarthur0 mentioned this issue Jun 4, 2020
Merged
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Jun 5, 2020
@araujoarthur0
Fix thamara#255: avoiding preferences save when still null
4348ea8
tupaschoal pushed a commit that referenced this issue Jun 5, 2020
@araujoarthur0
Fix #255: avoiding preferences save when still null (#261)
cb4cee1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #255: avoiding preferences save when still null araujoarthur0/time-to-leave
2 participants
@tupaschoal @araujoarthur0