Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall balance performance issue #334

Closed
araujoarthur0 opened this issue Jul 31, 2020 · 2 comments · Fixed by #336
Closed

Overall balance performance issue #334

araujoarthur0 opened this issue Jul 31, 2020 · 2 comments · Fixed by #336
Assignees
Labels
bug Something isn't working

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
After the addition of the overall balance feature, there's been a considerable performance degradation on TTL.

To Reproduce
Steps to reproduce the behavior:

  1. Open TTL and see it taking a few seconds to load up, and images as well (gif attached).
  2. If you use Developer Tools and run Profiler, you'll see "ComputeAllTimeBalanceUntil" as a big villain.

Expected behavior
No performance issues :)

Environment

Version: 1.5.5
Electron: 9.1.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
OS: Windows_NT ia32 10.0.17763

Screenshots
delay
image

Additional context
Add any other context about the problem here.

@araujoarthur0 araujoarthur0 added the bug Something isn't working label Jul 31, 2020
@tupaschoal
Copy link
Collaborator

I thought it was async? If not maybe it should

I noticed we should also cache it or be smarter on when to request it, because if I'm not mistaken, changing months or changing from day to month view trigger it to be recalculated, but it didn't really need to

@thamara
Copy link
Owner

thamara commented Jul 31, 2020

I thought it was async. At least I had tried going in that direction. But I might have messed something up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants