Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in Workday Waiver Manager doesn't match any of the app's theme #443

Closed
thamara opened this issue Oct 12, 2020 · 2 comments · Fixed by #448
Closed

Links in Workday Waiver Manager doesn't match any of the app's theme #443

thamara opened this issue Oct 12, 2020 · 2 comments · Fixed by #448
Assignees
@fikimaul
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest

Comments

@thamara
Copy link
Owner

thamara commented Oct 12, 2020

In Workday Waiver Manager, we have a link color for the tabs on the top of the page (for Add Waiver and Holiday). The not current item has a blue font, which doesn't match any of the themes in TTL

Dark:
image

Light:
image

Cadent Star:
image

I don't think it should be any link specific color, instead, just follow the theme's text color.
@thamara thamara added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 12, 2020
@fikimaul
Copy link
Contributor

Hi, Can i work on this?

@thamara
Copy link
Owner Author

thamara commented Oct 12, 2020

Sure! I'll assign the issue to you.

@fikimaul fikimaul mentioned this issue Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fikimaul fikimaul

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change link color of non active navbar follow the theme's text color fikimaul/time-to-leave
2 participants
@thamara @fikimaul