Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link color of non active navbar follow the theme's text color #448

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

fikimaul
Copy link
Contributor

Related issue

Closes #443

Context / Background

Links in Workday Waiver Manager doesn't match any of the app's theme

What change is being introduced by this PR?

  • Change the color of non active navar link using var(--page-color)

How will this be tested?

image

image

image

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #448 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files          28       28           
  Lines        2536     2536           
  Branches      389      389           
=======================================
  Hits         1625     1625           
  Misses        805      805           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19234fd...24629df. Read the comment docs.

@thamara
Copy link
Owner

thamara commented Oct 12, 2020

Thank you @fikimaul for the changes and for well-written description with screenshots. :D

@thamara
Copy link
Owner

thamara commented Oct 12, 2020

\changelog-update
Message: Enhancementnt: [#448] Changed link color in Workday Waiver Manager to match themes
User: fikimaul

@thamara thamara merged commit f152bc4 into thamara:main Oct 12, 2020
@fikimaul fikimaul deleted the change-link-color branch October 12, 2020 09:27
thamara pushed a commit to jcombs0929/time-to-leave that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in Workday Waiver Manager doesn't match any of the app's theme
2 participants