Disable/enable tray punch #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thamara
requested changes
Oct 25, 2019
tupaschoal
requested changes
Oct 25, 2019
tupaschoal
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#70
Context / Background
Tray punch button now follows the behaviour of the punch time button. It is disabled if the day is a non-working day or if all entries have already been punched.
What change is being introduced by this PR?
I added an observer on the punch button to see if the attribute changes to disabled. The result of this condition will send the value to main, setting the enabled key in the contextMenuTemplate. The tray menu will be rebuilt on dynamic values.