Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #152: adding copy button to about #230

Merged
merged 1 commit into from
May 16, 2020

Conversation

araujoarthur0
Copy link
Collaborator

Related issue

#152

Context / Background

  • Briefly explain the purpose of the PR by providing a summary of the context

Adding a copy button to copy the contents of the about section into the clipboard.
Very simple commit, adds a handler to the onSuccess of the About dialog Promise, that handles the pressing of the copy button. The clipboard module is used, from electron.

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #230 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   35.70%   35.46%   -0.25%     
==========================================
  Files          11       11              
  Lines         591      595       +4     
  Branches      101      102       +1     
==========================================
  Hits          211      211              
- Misses        337      340       +3     
- Partials       43       44       +1     
Impacted Files Coverage Δ
main.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909a085...ee00fdb. Read the comment docs.

@thamara thamara merged commit e056fd0 into thamara:master May 16, 2020
@thamara thamara added this to the v1.5.2 milestone May 16, 2020
@araujoarthur0 araujoarthur0 deleted the about_copy branch June 19, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants