Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #244: waiver opens with filled date when clicking from calendar #262

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

araujoarthur0
Copy link
Collaborator

@araujoarthur0 araujoarthur0 commented Jun 5, 2020

Related issue

Closes #244

Context / Background

  • Briefly explain the purpose of the PR by providing a summary of the context

When clicking from the calendar to open a waiver with the date pre-filled, it now works as expected.

What change is being introduced by this PR?

  • How did you approach this problem?

Just removing a check that was avoiding the filling to happen.

How will this be tested?

  • How will you verify whether your changes worked as expected once merged?

Works here.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   55.08%   55.12%   +0.04%     
==========================================
  Files          13       13              
  Lines        1220     1219       -1     
  Branches      218      217       -1     
==========================================
  Hits          672      672              
  Misses        480      480              
+ Partials       68       67       -1     
Impacted Files Coverage Δ
main.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42da2ad...85ae5cf. Read the comment docs.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry, please

@araujoarthur0
Copy link
Collaborator Author

Done

@tupaschoal tupaschoal merged commit 2f33cd2 into thamara:master Jun 5, 2020
@araujoarthur0 araujoarthur0 deleted the waiver-filled branch June 19, 2020 01:38
@tupaschoal tupaschoal added this to the v1.5.3 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening Waiver from table doesn't fill up date
2 participants