Fix #258: Fixing crash when changing network while opening TTL #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 55.08% 56.64% +1.56%
==========================================
Files 13 13
Lines 1220 1234 +14
Branches 218 221 +3
==========================================
+ Hits 672 699 +27
+ Misses 480 468 -12
+ Partials 68 67 -1
Continue to review full report at Codecov.
|
tupaschoal
reviewed
Jun 19, 2020
araujoarthur0
force-pushed
the
network-err
branch
from
62f9154
to
6c14a71
Compare
|
I mean, it doesn't really fiiiix, it just hides the exception and exits gracefully, I wonder if we can or should pursue fixing it, as it's a corner case. |
|
Yeah, since the stack trace doesn't really say anything, I couldn't be sure if there is one thing in the code that is leading to this error. |
tupaschoal
approved these changes
Jun 19, 2020
araujoarthur0
force-pushed
the
network-err
branch
from
6c14a71
to
9342e1e
Compare
|
Added |
tupaschoal
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #258: Fixing crash when changing network while opening TTL
Context / Background
While changing network and opening TTL at the same time, a network err exception is thrown and never caught anywhere.
What change is being introduced by this PR?
This PR adds a global catcher just for this exception.
How will this be tested?
Forced the same conditions that caused the issue and didn't see it happen :)