New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user-preferences test #880
Conversation
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 71.99% 74.24% +2.24%
==========================================
Files 17 17
Lines 1721 1747 +26
Branches 264 268 +4
==========================================
+ Hits 1239 1297 +58
+ Misses 482 450 -32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contribution! Left some comments mostly about consistency, but I love this :)
\changelog-update |
Related issue
Closes #868
Context / Background
Adds an extensive suite of tests to
user-preferences.js
and a couple of fixesas a consequence of these tests.
What change is being introduced by this PR?
I tried to get 100% coverage on the test going over all the functions.
Some preferences like
theme
,view
,language
were not being updated while testing so Ihad to change the bitwise assignment clause. Also added the validation for
overall-balance-start-date
andupdate-remind-me-after
.How will this be tested?
The issue is about tests :)