Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to the truly minimal routing on each services #12

Closed
thangchung opened this issue Jun 11, 2021 · 0 comments
Closed

Refactor to the truly minimal routing on each services #12

thangchung opened this issue Jun 11, 2021 · 0 comments
Assignees

Comments

@thangchung
Copy link
Owner

thangchung commented Jun 11, 2021

  1. To make it truly minimal, we need to refactor it to Map router on each service (that's mean we remove Swagger on each host, but I think after 6.0.100-preview.6.21308.9 SDK released, then we can bring back Swagger, see at https://github.com/halter73/swagger), and map it like https://github.com/halter73/MinimalWeather/blob/main/dotnet/MinimalWeather/Program.cs and https://github.com/dodyg/practical-aspnetcore/blob/net5.0/projects/net6/web-application-8/src/Program.cs, and https://github.com/425show/MinimalWeather/blob/main/Program.cs

  2. Refactor to 3 projects (one service - core + app and API only to make it is more simply), refactor App layer only contain interfaces + use cases + model only (and depends on Infrastructure layer)

  • CoreApp: Core + App layers
  • Infrastructure layer
  • API layer
  1. Then we write the aggregator like https://github.com/dotnet-architecture/eShopOnContainers/tree/dev/src/ApiGateways/Web.Bff.Shopping/aggregator, the reason is we need one centralize endpoints with swagger.json file, then we will use some kind of Swagger Client Generator like https://github.com/RicoSuter/NSwag/wiki/NSwagStudio to generate the HTTP client with all APIs we have. Then we can use it inside the Blazor app (we gonna refactor to remove the current web which is implemented using nextjs. But need to investigate more
@thangchung thangchung self-assigned this Jun 11, 2021
thangchung added a commit that referenced this issue Jun 11, 2021
thangchung added a commit that referenced this issue Jun 12, 2021
thangchung added a commit that referenced this issue Jun 12, 2021
thangchung added a commit that referenced this issue Jun 12, 2021
thangchung added a commit that referenced this issue Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant