Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The under code in 'Avoid magic string' title must change to const #28

Closed
hasanaliagar opened this issue Jan 7, 2019 · 2 comments
Closed

The under code in 'Avoid magic string' title must change to const #28

hasanaliagar opened this issue Jan 7, 2019 · 2 comments
Assignees
@thangchung
Labels
enhancement

Comments

@hasanaliagar
Copy link

I think so ADMIN_ROLE variable must const.
const string ADMIN_ROLE = "Admin";
@thangchung thangchung self-assigned this Jan 16, 2019
@thangchung
Copy link
Owner

@hasanaliagar07 Thank you for your suggestion. Could you do a PR? Then I'm happy to merge it 👍

thangchung added a commit that referenced this issue Jan 18, 2019
@thangchung
Add const with suggestion from #28
4cecbd0
@thangchung
Copy link
Owner

I have fixed at Avoid magic string sub-item. Thank you very much again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thangchung thangchung

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thangchung @hasanaliagar