*: prepare for multi-key fetch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
prepare_for_multi_key_fetch
branch
from
00c6fa7
to
7265abb
Compare
Upgrade internal interfaces for multi-key fetch: - Use multi-part HTTP request/response for retrieving data about multiple keys. Boundary is randomly generated by Go standard library so this seems like the best path; - Upgrade gRPC interface to have `repeat string Keys` instead of `string Key`. `key` has priority over `keys` but users should use `keys` either way. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade internal interfaces for multi-key fetch:
multiple keys. Boundary is randomly generated by Go standard library so
this seems like the best path;
repeat string Keysinstead ofstring Key.keyhas priority overkeysbut users should usekeyseitherway.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com