Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No quotation marks on alert.label-drop #116

Merged
merged 2 commits into from
May 15, 2020
Merged

No quotation marks on alert.label-drop #116

merged 2 commits into from
May 15, 2020

Conversation

gaetanars
Copy link

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

kakkoyun
kakkoyun requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Could you also open an issue to report the problem?

And CI fails. You have to sign the DCO. Also, you need to run make generate and commit change for generated files as well.

examples/all/manifests/thanos-rule-statefulSet.yaml Show resolved Hide resolved
@gaetanars
No quotation marks on alert.label-drop
a32bc7b 
Signed-off-by: Gaëtan Ars <gaetan.ars@orange.com>
@gaetanars gaetanars mentioned this pull request Apr 30, 2020
Closed
alert.label-drop without quotations mark
c85ac95 
Signed-off-by: Gaëtan Ars <gaetan.ars@orange.com>
@gaetanars gaetanars requested a review from kakkoyun May 4, 2020 14:41
@kakkoyun kakkoyun requested a review from metalmatze May 4, 2020 14:44
metalmatze
metalmatze approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks.

@metalmatze metalmatze merged commit 96ae241 into thanos-io:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@kakkoyun kakkoyun Awaiting requested review from kakkoyun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaetanars @kakkoyun @metalmatze