receive: Use anti-affinity to spread across zones #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
|
I want to double check this still works on nodes that don't have the label. I think it does, but I want to double check. |
|
Double checked, works just fine :) |
bwplotka
reviewed
Apr 29, 2020
| @@ -38,6 +38,17 @@ spec: | |||
| - thanos | |||
| topologyKey: kubernetes.io/hostname | |||
| weight: 100 | |||
| - podAffinityTerm: | |||
There was a problem hiding this comment.
Hmm I would expect podAntiAffinity, no?
There was a problem hiding this comment.
The wording is extremely confusing I agree, but it's under the podAntiAffinity object, so this does what we expect.
There was a problem hiding this comment.
ah, diff was not even showing this word... (: Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frederic Branczyk fbranczyk@gmail.com
Changes
Spread receive pods across zones.
Verification
Tried the example manifests.
@bwplotka @metalmatze @squat @kakkoyun @krasi-georgiev