azure: Add new storage_create_container configuration property #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
force-pushed
the
azure-container-creation
branch
from
b7b291d
to
17b57bf
Compare
willyborankin
force-pushed
the
azure-container-creation
branch
from
17b57bf
to
a46a750
Compare
willyborankin
force-pushed
the
azure-container-creation
branch
3 times, most recently
from
8f1a925
to
1a36c0c
Compare
In some cases account does not have permissions to read container properties or create one but has all permissions to do CRUD operations inside the container, e.g. SAS tokens. To solve such use case the new configuration property was added for the Azure object storage config which creates a new container explicitly by settings `storage_create_container` to `true`. To keep backward compatibility with existing object storage configurations the default value for it is always `true`. Signed-off-by: Andrey Pleskach <ples@aiven.io>
Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
force-pushed
the
azure-container-creation
branch
from
1a36c0c
to
ba809cc
Compare
saswatamcode
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases account does not have permissions to read container properties or create one but has all permissions to do CRUD operations inside the container, e.g SAS tokens. To solve such use case the new configuration property was added for the Azure object storage config which creates a new container explicitly by settings
storage_create_containertotrueorfalse. To keep backward compatibility with existing object storage configurations the default value for it is alwaystrue.Changes
azure: Add new storage_create_container configuration property
Verification