function: add support for absent() #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jan 16, 2023
| http_requests_total{pod="nginx-1"} 0 | ||
| http_requests_total{pod="nginx-2"} 1`, | ||
| query: "absent(http_requests_total[30s])", | ||
| }, |
There was a problem hiding this comment.
Can you add another test case where there is no data matching the queried series at all?
GiedriusS
reviewed
Jan 20, 2023
|
can you suggest how i can fix this |
yeya24
reviewed
Jan 28, 2023
execution/function/functions.go
Outdated
| @@ -66,6 +66,21 @@ var Funcs = map[string]FunctionCall{ | |||
| "asinh": simpleFunc(math.Asinh), | |||
| "acosh": simpleFunc(math.Acosh), | |||
| "atanh": simpleFunc(math.Atanh), | |||
| "absent": func(f FunctionArgs) promql.Sample{ | |||
There was a problem hiding this comment.
I guess we need to fix the series labels. Please refer to upstream Prometheus and see how it implements absent https://github.com/prometheus/prometheus/blob/main/promql/functions.go#L591
There was a problem hiding this comment.
should i try to implement functions in promql-engine in similar way as promql function in prometheus
|
@zeus2611 you can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nischay itsnischay2604@gmail.com
add support for absent(), related issue #138