Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Prometheus and add context #244

Merged
merged 1 commit into from Apr 23, 2023
Merged

update Prometheus and add context #244

merged 1 commit into from Apr 23, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Apr 22, 2023

Update Prometheus to main and bring prometheus/prometheus@fd3630b.

@yeya24
update Prometheus and add context
777e21d 
Signed-off-by: Ben Ye <benye@amazon.com>
fpetkovski
fpetkovski approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. How is the context supposed to be used now? Should we propagate it to the query, or will the query get its own context?

@yeya24
Copy link
Contributor Author

yeya24 commented Apr 23, 2023

In my usecase, I am thinking I can use the context to propagate user ID and use that as part of the query optimizing logic.

@yeya24 yeya24 merged commit 1c83edb into thanos-io:main Apr 23, 2023
4 checks passed
@yeya24 yeya24 deleted the add-ctx branch April 23, 2023 18:38
@ahurtaud ahurtaud mentioned this pull request May 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yeya24 @fpetkovski