-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: format load strings in tests #282
fmt: format load strings in tests #282
Conversation
ba092b5
to
daeac04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
We should probably hook this into our CI as well, by adding it to format
target.
ci/loadvet/main.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe making this into its own module, so that it is separately installable might be better, in case we want to upstream it for use in prometheus/prometheus at some point? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can to run this during CI and error out if there are any changes after running this tool?
Running it in the CI seems like a good idea 👍 |
daeac04
to
d078d7b
Compare
hooked it up to the "format" job |
12d908c
to
2bf59ad
Compare
9111740
to
0d9c7d7
Compare
* added small tool to automatically format tests * reformatted all tests Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
0d9c7d7
to
a059bcd
Compare
Adds a small tool so we can auto-format indentation for load statements.