-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execution: rework binary operators, add set operatos #318
Merged
yeya24
merged 1 commit into
thanos-io:main
from
MichaHoffmann:mhoffm-rework-binary-operator
Oct 2, 2023
Merged
execution: rework binary operators, add set operatos #318
yeya24
merged 1 commit into
thanos-io:main
from
MichaHoffmann:mhoffm-rework-binary-operator
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichaHoffmann
commented
Sep 27, 2023
•
edited
Loading
edited
- rewritten binary operators ( really no good reason; it just kinda happened )
- added support for "and, or, unless" ( prepared support for native histograms but that will be followup )
- fixed some bugs in our duplicate label detection logic
- fixed minor bug in error reporting for hash collision on left side in a one-to-one matching
MichaHoffmann
force-pushed
the
mhoffm-rework-binary-operator
branch
4 times, most recently
from
September 30, 2023 13:33
0e8edf3
to
adecda9
Compare
|
MichaHoffmann
force-pushed
the
mhoffm-rework-binary-operator
branch
2 times, most recently
from
September 30, 2023 14:19
239d11e
to
337b02b
Compare
MichaHoffmann
force-pushed
the
mhoffm-rework-binary-operator
branch
3 times, most recently
from
September 30, 2023 14:35
8374744
to
0ce81cb
Compare
MichaHoffmann
force-pushed
the
mhoffm-rework-binary-operator
branch
2 times, most recently
from
October 2, 2023 14:20
2a4e078
to
005a074
Compare
fpetkovski
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the improvements, great work 👍
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-rework-binary-operator
branch
from
October 2, 2023 17:31
005a074
to
d84949c
Compare
yeya24
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.