Switch to use Miekg by default (#4519)

* Switch to use Miekg by default Signed-off-by: clyang82 <chuyang@redhat.com> * Update changelog.md Signed-off-by: clyang82 <chuyang@redhat.com> * Address review comments Signed-off-by: clyang82 <chuyang@redhat.com>
thanos-io · Aug 5, 2021 · 0e9cc46 · 0e9cc46
1 parent 0536ba6
commit 0e9cc46
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 - [#4476](https://github.com/thanos-io/thanos/pull/4476) UI: fix incorrect html escape sequence used for '>' symbol.
 
 ### Changed
+- [#4519](https://github.com/thanos-io/thanos/pull/4519) Query: switch to miekgdns DNS resolver as the default one.
 
 ## [v0.22.0](https://github.com/thanos-io/thanos/tree/release-0.22) - 2021.07.22
 

diff --git a/cmd/thanos/query.go b/cmd/thanos/query.go
@@ -127,7 +127,7 @@ func registerQuery(app *extkingpin.App) {
 		Default("30s"))
 
 	dnsSDResolver := cmd.Flag("store.sd-dns-resolver", fmt.Sprintf("Resolver to use. Possible options: [%s, %s]", dns.GolangResolverType, dns.MiekgdnsResolverType)).
-		Default(string(dns.GolangResolverType)).Hidden().String()
+		Default(string(dns.MiekgdnsResolverType)).Hidden().String()
 
 	unhealthyStoreTimeout := extkingpin.ModelDuration(cmd.Flag("store.unhealthy-timeout", "Timeout before an unhealthy store is cleaned from the store UI page.").Default("5m"))
 

diff --git a/pkg/cacheutil/memcached_client.go b/pkg/cacheutil/memcached_client.go
@@ -247,7 +247,7 @@ func newMemcachedClient(
 		addressProvider = dns.NewProvider(
 			logger,
 			extprom.WrapRegistererWithPrefix("thanos_memcached_", reg),
-			dns.GolangResolverType,
+			dns.MiekgdnsResolverType,
 		)
 	}